vSphere: Add IPI-specific validation. #3372
Conversation
Refactors VIP checks into a reusable helper function, adding a distinction between required/invalid VIPs, and updating tests accordingly.
Adds platform validation when loading install config.
patrickdillon
force-pushed
the
vsphere-ipi-validate
branch
from
9e4f7f1
to
632c426
Compare
|
Using ipi UPI in code imo is not great! Let's find more appropriate names Secondly, I think we should not overload the tfvars asset, rather create a new one that can perform this validation like the permissions check... |
patrickdillon
force-pushed
the
vsphere-ipi-validate
branch
3 times, most recently
from
1ff3573
to
17b7357
Compare
@abhinavdahiya PTAL also please check the related PR openshift/release#7989 |
patrickdillon
force-pushed
the
vsphere-ipi-validate
branch
from
17b7357
to
0b788d0
Compare
|
/test e2e-vsphere |
| // ValidateForProvisioning performs platform validation specifically for installer- | ||
| // provisioned infrastructure. In this case, self-hosted networking is a requirement | ||
| // when the installer creates infrastructure for vSphere clusters. | ||
| func ValidateForProvisioning(ic *types.InstallConfig) error { |
There was a problem hiding this comment.
shouldn't this call the Validate ?
There was a problem hiding this comment.
I don't think so? Validate would already be called when loading installconfig asset in cd4aee1
|
/approve overall looks good, just few comments. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This commit creates a new asset to perform platform validation specifically for cluster creation. This is useful for when UPI and IPI install configs may have different requirements. In the case of vSphere, IPI requires cluster and VIPs but these are optional in UPI. IPI requires the following fields which are optional for UPI: - Network - Cluster - APIVIP - IngressVIP - DNSVIP
Generated with: $ openshift-install graph | dot -Tsvg >docs/design/resource_dep.svg using: $ dot -V dot - graphviz version 2.40.1 (0)
patrickdillon
force-pushed
the
vsphere-ipi-validate
branch
from
0b788d0
to
c7540c0
Compare
|
/test e2e-vsphere LGTM, just waiting for these jobs to finish |
|
/test e2e-vsphere-upi |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
vSphere IPI requires fields in the install-config that are optional in UPI, specifically
cluster,network, and the VIPs. In order to not break previous working IPI installs 7e82337 performs this IPI-specific validation when creating tfvars.Jira: CORS-1354
Related: openshift/release#7989