Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vSphere: Add IPI-specific validation. #3372

Merged
merged 5 commits into from
Apr 2, 2020
Merged

vSphere: Add IPI-specific validation. #3372

merged 5 commits into from
Apr 2, 2020

Commits on Mar 30, 2020

  1. vSphere: Refactor VIP validation for Platform. 

    Refactors VIP checks into a reusable helper function, adding a distinction between required/invalid VIPs, and updating tests accordingly.
    @patrickdillon
    patrickdillon committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    10d127c View commit details
    Browse the repository at this point in the history

  2. vSphere: Add platform validation. 

    Adds platform validation when loading install config.
    @patrickdillon
    patrickdillon committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    cd4aee1 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. vSphere: Add IPI-specific platform validation. 

    This commit creates a new asset to perform platform validation specifically for cluster creation. This is useful for when UPI and IPI install configs may have different requirements. In the case of vSphere, IPI requires cluster and VIPs but these are optional in UPI.

IPI requires the following fields which are optional for UPI:
- Network
- Cluster
- APIVIP
- IngressVIP
- DNSVIP
    @patrickdillon
    patrickdillon committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    eacf2ba View commit details
    Browse the repository at this point in the history

  2. vSphere: Add install config validation unit tests

    @patrickdillon
    patrickdillon committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    a700105 View commit details
    Browse the repository at this point in the history

  3. docs/design/resource_dep: Update dependency graph. 

    Generated with:
$ openshift-install graph | dot -Tsvg >docs/design/resource_dep.svg

using:
$ dot -V
dot - graphviz version 2.40.1 (0)
    @patrickdillon
    patrickdillon committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    c7540c0 View commit details
    Browse the repository at this point in the history