Bug 1821151: oVirt, add os_type to ovirt templates #3418
Conversation
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@Gal-Zaidman: This pull request references Bugzilla bug 1821151, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc rgolangh |
|
/retest |
|
/test e2e-ovirt |
|
@Gal-Zaidman a nit - in the PR message you say "os_type=rchos" fix that so it won't confuse future readers. |
openshift-ci-robot
added
the
needs-rebase
On RHV 4.3.9 we have change the ignition handling and API, to recognize an ignition is passed to the VM we need to specify the os_type as RHCOS. During the installation the installer creates a ovirt templates to be used by the nodes, so we need to create the template with os_type = "rchos". Signed-off-by: Gal Zaidman <gzaidman@redhat.com>
Signed-off-by: Gal Zaidman <gzaidman@redhat.com>
openshift-ci-robot
removed
the
needs-rebase
|
/lgtm |
|
/lgtm |
|
/assign @smarterclayton |
|
/assign @abhinavdahiya |
|
@abhinavdahiya or @sdodson this needs approval, please |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@Gal-Zaidman: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
On RHV 4.3.9 we have change the ignition handling and API,
to recognize an ignition is passed to the VM we need to specify the os_type as RHCOS.
During the installation the installer creates a ovirt templates to be used by the nodes,
so we need to create the template with os_type = "rchos".
Signed-off-by: Gal Zaidman gzaidman@redhat.com