-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1819492: vsphere upi and metal: terraform 0.12.x update, general updates and reorg #3429
Bug 1819492: vsphere upi and metal: terraform 0.12.x update, general updates and reorg #3429
Conversation
2ffa2ab
to
c66f34f
Compare
@jcpowermac feel free to include/cherry pick the two remaining commits from #3235 on this PR (I've removed the commit regarding vsphere from there) |
/test e2e-vsphere-upi |
/test e2e-vsphere |
/retest |
can we get this unstuck? |
4fc480b
to
e33383b
Compare
/test e2e-vsphere-upi |
/test e2e-metal |
vsphere test failure:
/test e2e-vsphere-upi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nit. I also think it'd be cleaner to amend the metal commit to include the rebase changes.
e33383b
to
e89c0c1
Compare
/test e2e-vsphere-upi |
/test e2e-metal |
vsphere needs this change: |
/test e2e-vsphere-upi |
1 similar comment
/test e2e-vsphere-upi |
/test e2e-vsphere-upi |
vsphere status:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, LorbusChris, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
let's keep the hold untill metal e2e CI job at least completes setup |
I think as of today this also requires a |
@jcpowermac: This pull request references Bugzilla bug 1819492, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-metal |
1 similar comment
/test e2e-metal |
/retest |
Packet and matchbox problems maybe auth in https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_installer/3429/pull-ci-openshift-installer-master-e2e-metal/214 |
@jcpowermac: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-metal |
metal e2e has passed. /hold cancel |
/override e2e-aws |
@sdodson: /override requires a failed status context to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/e2e-aws |
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@jcpowermac: All pull requests linked via external trackers have merged: openshift/installer#3429. Bugzilla bug 1819492 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@jcpowermac: #3429 failed to apply on top of branch "release-4.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…es and reorg - Update to terraform 0.12.x - ipam moved to a module and updated for 0.12 - creation of vsphere objects moved to module - removal of etcd dns records - domain dns records separated from creating rhcos node a records - create load balancer using openshift haproxy image and an additional rhcos virtual machine - create dns A record for lb ip and api, api-int, *.apps - change virtual machine ignition extra config to file path string vs ignition string. Simplifies bootstrap and other instance configuration - Updated Dockerfile CI UPI image for 0.12.24
rhcos virtual machine
ignition string. Simplifies bootstrap and other instance configuration