pkg/asset/installconfig: add vSphere TUI wizard #3467
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
/cc @jcpowermac |
|
This looks really good. The only thing from my perspective is the network comment. |
|
@patrickdillon #3470 |
patrickdillon
force-pushed
the
vsphere-tui-cors-1415
branch
from
5dc7157
to
3d090b5
Compare
patrickdillon
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
I have addressed the networks issue and outstanding items, so I'm moving this out of WIP and I think it is ready. |
|
FYI: This won't pass |
e2e-vsphere has an install-config so this PR might incorrectly pass. But that reminds me we should update steps job. I will open a PR. |
|
/lgtm |
|
|
||
| // Survey does not allow validation of groups of input | ||
| // so we perform our own validation. | ||
| logrus.Infof("Connecting to vCenter %s", vcenter) |
There was a problem hiding this comment.
i think we should move this to debug.
There was a problem hiding this comment.
I used Info because there is a noticeable delay for the network connection. This lets the user know what's happening and that the process is not frozen. The pause is very short, a few seconds in my case, so I'm willing to change but wanted to explain the reasoning.
patrickdillon
force-pushed
the
vsphere-tui-cors-1415
branch
from
3d090b5
to
6ba3d67
Compare
patrickdillon
force-pushed
the
vsphere-tui-cors-1415
branch
from
6ba3d67
to
335e931
Compare
This commit adds the survey prompts to create an install config. After querying the user for credentials, the wizard uses the vCenter API to present choices for all options.
patrickdillon
force-pushed
the
vsphere-tui-cors-1415
branch
from
335e931
to
48cc11e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This pull request adds the interactive wizard for creating a vSphere install config. After querying credentials from the user, the options are populated from the vCenter API. In cases where only one option is available, it is automatically selected.
This is WIP, but is mostly done, so I am posting for general feedback as well as specific feedback regarding networks. There seem to be four types of vSphere networks. In our vcenter there are DistributedVirtualPortGroups and DistributedVirtualSwitches, and some of these have children. Are all of these valid selections or should I be filtering some of them? The network list is pulled here: https://github.com/openshift/installer/compare/master...patrickdillon:vsphere-tui-cors-1415?expand=1#diff-8366d626249d949112555caeac30a52cR262
Here is a screenshot of the wizard:
On my to-do list: