New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vsphere ipi: align with baremetal and remove DNSVIP #3470
Conversation
These changes remove the required field `NodeDNSIP` from openshift/api and `DNSVIP` from the vsphere platform.
/hold |
MCO Change: openshift/machine-config-operator#1657 |
/lgtm |
MCO update: |
/approve /retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
These changes remove the required field
NodeDNSIP
from openshift/apiand
DNSVIP
from the vsphere platform.