Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.4] Bug 1825460: OpenStack: Replace remote_group_id with remote_ip_prefix #3477

Merged
merged 1 commit into from Apr 20, 2020
Merged

[release-4.4] Bug 1825460: OpenStack: Replace remote_group_id with remote_ip_prefix #3477

merged 1 commit into from Apr 20, 2020

Conversation

pierreprinetti
Copy link
Member

OpenStack with OVS has an issue where security groups using
remote_group_id can be very slow, leading to OVS dropping packets.

https://bugzilla.redhat.com/show_bug.cgi?id=1703947

Use remote_ip_prefix instead to workaround the issue.

This is a cherry-pick of #3461

@mandre @pierreprinetti
OpenStack: Replace remote_group_id with remote_ip_prefix
82de7e0 
OpenStack with OVS has an issue where security groups using
remote_group_id can be very slow, leading to OVS dropping packets.

https://bugzilla.redhat.com/show_bug.cgi?id=1703947

Use remote_ip_prefix instead to workaround the issue.
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Bugzilla bug 1825460, which is invalid:

  • expected dependent Bugzilla bug 1824287 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.4] Bug 1825460: OpenStack: Replace remote_group_id with remote_ip_prefix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 18, 2020
@pierreprinetti
Copy link
Member Author

/uncc jhixson74 patrickdillon
/cc @mandre @iamemilio @Fedosin @adduarte
/label platform/openstack

@pierreprinetti
Copy link
Member Author

/assign mandre

@pierreprinetti
Copy link
Member Author

e2e-openstack succeeded!

/cherry-pick release 4.3

@openshift-cherrypick-robot
Copy link

@pierreprinetti: once the present PR merges, I will cherry-pick it on top of release 4.3 in a new PR and assign it to you.

In response to this:

e2e-openstack succeeded!

/cherry-pick release 4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti mentioned this pull request Apr 18, 2020
Merged
@mandre mandre mentioned this pull request Apr 20, 2020
Merged
@pierreprinetti
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 20, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Bugzilla bug 1825460, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1824287 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1824287 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 20, 2020
@pierreprinetti
Copy link
Member Author

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
@sdodson
Copy link
Member

sdodson commented Apr 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 20, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 20, 2020 •
edited

@pierreprinetti: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 82de7e0 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Apr 20, 2020

/override ci/prow/e2e-aws-upgrade
These changes are entirely localized to openstack and thus e2e-aws-upgrade is not relevant.

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-upgrade

In response to this:

/override ci/prow/e2e-aws-upgrade
These changes are entirely localized to openstack and thus e2e-aws-upgrade is not relevant.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 2faa8d7 into openshift:release-4.4 Apr 20, 2020
@openshift-cherrypick-robot
Copy link

@pierreprinetti: cannot checkout release 4.3: error checking out release 4.3: exit status 1. output: error: pathspec 'release 4.3' did not match any file(s) known to git.

In response to this:

e2e-openstack succeeded!

/cherry-pick release 4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: All pull requests linked via external trackers have merged: openshift/installer#3477. Bugzilla bug 1825460 has been moved to the MODIFIED state.

In response to this:

[release-4.4] Bug 1825460: OpenStack: Replace remote_group_id with remote_ip_prefix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the openstack-sg-4.4 branch April 20, 2020 15:38
@pierreprinetti
Copy link
Member Author

/cherry-pick release-4.3

@openshift-cherrypick-robot
Copy link

@pierreprinetti: #3477 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	data/data/openstack/topology/sg-master.tf
M	data/data/openstack/topology/sg-worker.tf
Falling back to patching base and 3-way merge...
Auto-merging data/data/openstack/topology/sg-worker.tf
CONFLICT (content): Merge conflict in data/data/openstack/topology/sg-worker.tf
Auto-merging data/data/openstack/topology/sg-master.tf
CONFLICT (content): Merge conflict in data/data/openstack/topology/sg-master.tf
Patch failed at 0001 OpenStack: Replace remote_group_id with remote_ip_prefix

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti mentioned this pull request Apr 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adduarte adduarte Awaiting requested review from adduarte

@Fedosin Fedosin Awaiting requested review from Fedosin

@iamemilio iamemilio Awaiting requested review from iamemilio

@mandre mandre Awaiting requested review from mandre

Assignees

@sdodson sdodson

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pierreprinetti @openshift-ci-robot @openshift-cherrypick-robot @sdodson @openshift-bot @mandre @openshift-merge-robot