Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.3] Bug 1825478: OpenStack CI Install awscli from zip #3478

Merged
merged 1 commit into from Apr 23, 2020
Merged

[release-4.3] Bug 1825478: OpenStack CI Install awscli from zip #3478

merged 1 commit into from Apr 23, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3110

/assign pierreprinetti

@mandre
Bug 1803174: OpenStack CI Install awscli from zip
b14e05c 
Building OpenStack CI image started failing because it cannot install
awscli package from the repositories.

Let's follow the instruction from AWS rather than installing via yum:

https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-linux.html
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 18, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: An error was encountered searching for bug 1803174 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1803174?api_key=CENSORED: dial tcp: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.3] Bug 1803174: OpenStack CI Install awscli from zip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member

/retitle [release-4.3] Bug 1825478: OpenStack CI Install awscli from zip
/cc @mandre @Fedosin @adduarte @iamemilio
/uncc mtnbikenc jstuever
/label platform/openstack
/approve

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1803174: OpenStack CI Install awscli from zip [release-4.3] Bug 1825478: OpenStack CI Install awscli from zip Apr 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: An error was encountered searching for bug 1825478 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1825478?api_key=CENSORED: dial tcp: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.3] Bug 1825478: OpenStack CI Install awscli from zip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti mentioned this pull request Apr 18, 2020
Merged
@pierreprinetti
Copy link
Member

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/high bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 18, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Bugzilla bug 1825478, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1803174 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1803174 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member

pierreprinetti commented Apr 18, 2020 •
edited

There currently are two issues preventing the e2e-openstack presubmit job to succeed: the bug fixed here, and the security group inefficiency which fix is waiting to be backported. Until both patches land, there is little chance we can get the presubmit green.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mandre
Copy link
Member

mandre commented Apr 20, 2020

Although it shouldn't break anything in 4.3, I was under the impression 4.3 wasn't affected by https://bugzilla.redhat.com/show_bug.cgi?id=1803174... Do you have an example of failing job?

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mandre
Copy link
Member

mandre commented Apr 20, 2020

/lgtm
@pierreprinetti pointed me to the pre-submit jobs for #3466 that are effectively failing because of https://bugzilla.redhat.com/show_bug.cgi?id=1825478

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pierreprinetti
Copy link
Member

pierreprinetti commented Apr 20, 2020 •
edited

@sdodson
This is a test-blocker (no presubmit can go green without this patch).

However the openstack test will not turn green, because we also have to merge the security group fix.

Thank you 🙏

@sdodson
Copy link
Member

sdodson commented Apr 20, 2020

/lgtm

@sdodson
Copy link
Member

sdodson commented Apr 20, 2020

/override ci/prow/e2e-openstack
Test is still failing but not due to lack of awscli

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-openstack

In response to this:

/override ci/prow/e2e-openstack
Test is still failing but not due to lack of awscli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Apr 20, 2020 •
edited

How did we regress on 4.3 testing without these 4.4 fixes or is this not a regression just more of an overall stability fix? Lets get the batch of 4.4 fixes through and open them against 4.3. Will evaluate what to do once that's done, ping me on slack when that's done.

@pierreprinetti
Copy link
Member

We have two issues introduced from outside:

  • They removed awscli from the upstream image (fixed here)
  • Our infra started being brittle on the Neutron side (hence the secgroup "fix" which is actually an optimisation, without which our infra fails 100%)

This was referenced Apr 20, 2020
Merged
Merged
@russellb
Copy link
Member

@pierreprinetti I think it'd be helpful to leave a comment in the CI Dockerfile to note why awscli is needed at all since it's not obvious. Thanks!

@russellb russellb added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 22, 2020
@russellb russellb mentioned this pull request Apr 22, 2020
Merged
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Apr 23, 2020

/override ci/prow/e2e-gcp-upgrade
Changes in this PR are irrelevant to gcp.

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-gcp-upgrade

In response to this:

/override ci/prow/e2e-gcp-upgrade
Changes in this PR are irrelevant to gcp.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 1b8f3b1 into openshift:release-4.3 Apr 23, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/installer#3478. Bugzilla bug 1825478 has been moved to the MODIFIED state.

In response to this:

[release-4.3] Bug 1825478: OpenStack CI Install awscli from zip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adduarte adduarte Awaiting requested review from adduarte

@Fedosin Fedosin Awaiting requested review from Fedosin

@iamemilio iamemilio Awaiting requested review from iamemilio

@mandre mandre Awaiting requested review from mandre

Assignees

@sdodson sdodson

@mandre mandre

@pierreprinetti pierreprinetti

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @pierreprinetti @openshift-bot @mandre @sdodson @russellb @openshift-merge-robot