Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: Remove references to CoreOS Terraform #35

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

wking
Copy link
Member

@wking wking commented Jul 9, 2018

These were added in 15394f8 (coreos/tectonic-installer#1444), but we returned to upstream Terraform in all cases in 379fd19 (coreos/tectonic-installer#2041). Remove the stale docs.

@coreosbot
Copy link

Can one of the admins verify this patch?

These were added in 15394f8 (tests: Add upstream terraform trigger,
2017-07-21, coreos/tectonic-installer#1444), but we returned to
upstream Terraform in all cases in 379fd19 (Bump Terraform to 0.10.7,
2017-10-04, coreos/tectonic-installer#2041).  Remove the stale docs.
@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2018
@squat
Copy link
Contributor

squat commented Jul 9, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2018
@squat
Copy link
Contributor

squat commented Jul 9, 2018

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 9, 2018
@wking
Copy link
Member Author

wking commented Jul 9, 2018

The e2e-aws errors look like these.

@stevekuznetsov
Copy link
Contributor

/retest

@wking
Copy link
Member Author

wking commented Jul 9, 2018

All green :).

@wking
Copy link
Member Author

wking commented Jul 10, 2018

Grr. For some reason this has un-greened itself, and now e2e-aws is mad. I'd guess at least some of the 31 failures (!) are cascading from the first:

BeforeSuite 1m10s
go run hack/e2e.go -v -test --test_args='--ginkgo.focus=BeforeSuite$'
/tmp/openshift/build-rpms/rpm/BUILD/origin-3.11.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/e2e.go:140
Expected error:
    <*url.Error | 0xc4213a7cb0>: {
        Op: "Get",
        URL: "https://ci-op-5kjc6bg0-68485-api.origin-ci-int-aws.dev.rhcloud.com:6443/api/v1/nodes?fieldSelector=spec.unschedulable%3Dfalse&resourceVersion=0",
        Err: {},
    }
    Get https://ci-op-5kjc6bg0-68485-api.origin-ci-int-aws.dev.rhcloud.com:6443/api/v1/nodes?fieldSelector=spec.unschedulable%3Dfalse&resourceVersion=0: net/http: TLS handshake timeout
not to have occurred
/tmp/openshift/build-rpms/rpm/BUILD/origin-3.11.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/e2e.go:178

Maybe a networking hiccup?

@stevekuznetsov
Copy link
Contributor

/skip

@yifan-gu
Copy link
Contributor

/retest

@wking
Copy link
Member Author

wking commented Jul 20, 2018

The e2e-aws error was:

Waiting for router to be created ...
Waiting for API at https://ci-op-c35fpz2s-68485-api.origin-ci-int-aws.dev.rhcloud.com:6443 to respond ...
... lots of copies of that line...
Waiting for API at https://ci-op-c35fpz2s-68485-api.origin-ci-int-aws.dev.rhcloud.com:6443 to respond ...
Interrupted
2018/07/20 22:29:48 Container setup in pod e2e-aws failed, exit code 1, reason Error

The summary was:

operator Instantiate the template e2e-aws into the operator namespace and wait for any pods to complete 2h11m

go run hack/e2e.go -v -test --test_args='--ginkgo.focus=operator\sInstantiate\sthe\stemplate\se2e\-aws\sinto\sthe\soperator\snamespace\sand\swait\sfor\sany\spods\sto\scomplete$'

the pod ci-op-c35fpz2s/e2e-aws failed after 2h11m2s (failed containers: setup, test):  unknown

Container setup exited with code 1, reason Error
Container test exited with code 1, reason Error

@wking
Copy link
Member Author

wking commented Jul 25, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit 228f63d into openshift:master Jul 25, 2018
@wking wking deleted the drop-TERRAFORM_URL branch July 25, 2018 21:41
EmilienM pushed a commit to shiftstack/installer that referenced this pull request Dec 8, 2020
stbenjam pushed a commit to stbenjam/installer that referenced this pull request Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants