-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
images: Remove references to CoreOS Terraform #35
Merged
openshift-merge-robot
merged 1 commit into
openshift:master
from
wking:drop-TERRAFORM_URL
Jul 25, 2018
Merged
images: Remove references to CoreOS Terraform #35
openshift-merge-robot
merged 1 commit into
openshift:master
from
wking:drop-TERRAFORM_URL
Jul 25, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
These were added in 15394f8 (tests: Add upstream terraform trigger, 2017-07-21, coreos/tectonic-installer#1444), but we returned to upstream Terraform in all cases in 379fd19 (Bump Terraform to 0.10.7, 2017-10-04, coreos/tectonic-installer#2041). Remove the stale docs.
squat
approved these changes
Jul 9, 2018
/lgtm |
/ok-to-test |
The e2e-aws errors look like these. |
/retest |
All green :). |
Grr. For some reason this has un-greened itself, and now e2e-aws is mad. I'd guess at least some of the 31 failures (!) are cascading from the first:
Maybe a networking hiccup? |
/skip |
/retest |
The e2e-aws error was:
The summary was:
|
/retest |
This was referenced Aug 21, 2018
EmilienM
pushed a commit
to shiftstack/installer
that referenced
this pull request
Dec 8, 2020
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Feb 10, 2021
Add Bugzilla Component Information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were added in 15394f8 (coreos/tectonic-installer#1444), but we returned to upstream Terraform in all cases in 379fd19 (coreos/tectonic-installer#2041). Remove the stale docs.