Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCO: Update Linux Foundation address (to Letterman Drive) #26

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

wking
Copy link
Member

@wking wking commented Jul 6, 2018

Generated with:

$ curl -s https://developercertificate.org >DCO

after which I stripped the <pre> tags and everything outside of them.

@coreosbot
Copy link

Can one of the admins verify this patch?

@openshift-ci-robot
Copy link
Contributor

Hi @wking. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2018
@wking wking changed the title DCO: Update Linux foundation address (to Letterman Drive) DCO: Update Linux Foundation address (to Letterman Drive) Jul 6, 2018
Generated with:

  $ curl -s https://developercertificate.org >DCO

after which I stripped the <pre> tags and everything outside of them.
DCO
San Francisco, CA 94110 USA
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comma is needed between the state and the ZIP

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comma is needed between the state and the ZIP

This is what came out of curling https://developercertificate.org. With the DCO distributed under verbatim-copies-only terms, I don't think it's worth tuning their content. Maybe submit these suggestions upstream to the LF?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I missed that. this in indeed the content of the hosted document :/

DCO
660 York Street, Suite 102,
San Francisco, CA 94110 USA
1 Letterman Drive
Suite D4700
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this line need the building number too? Building D, Suite D4700? as in https://www.linuxfoundation.org/about/contact/

@squat
Copy link
Contributor

squat commented Jul 6, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2018
@squat squat merged commit 90239b0 into openshift:master Jul 6, 2018
@wking wking deleted the dco-lf-address branch July 7, 2018 00:12
@openshift-ci-robot
Copy link
Contributor

@wking: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws d32a8c1 link /test e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member Author

wking commented Jul 7, 2018

This PR had the same operator Instantiate the template e2e-aws into the operator namespace and wait for any pods to complete error as seen in #29. It also had:

[Conformance][Area:Networking][Feature:Router] The HAProxy router should set Forwarded headers appropriately [Suite:openshift/conformance/parallel] 0.80s
go run hack/e2e.go -v -test --test_args='--ginkgo.focus=\[Conformance\]\[Area\:Networking\]\[Feature\:Router\]\sThe\sHAProxy\srouter\sshould\sset\sForwarded\sheaders\sappropriately\s\[Suite\:openshift\/conformance\/parallel\]$'
/tmp/openshift/build-rpms/rpm/BUILD/origin-3.11.0/_output/local/go/src/github.com/openshift/origin/test/extended/util/cli.go:86
Jul  6 23:57:38.542: the server could not find the requested resource (post users.user.openshift.io)
/tmp/openshift/build-rpms/rpm/BUILD/origin-3.11.0/_output/local/go/src/github.com/openshift/origin/test/extended/util/cli.go:655

stbenjam pushed a commit to stbenjam/installer that referenced this pull request Apr 30, 2019
EmilienM pushed a commit to shiftstack/installer that referenced this pull request Dec 8, 2020
* check err on DeleteKeyPair

* check err on UpdateStatus
clnperez pushed a commit to clnperez/installer that referenced this pull request Aug 23, 2021
initial install-config.yaml generation via the user survey
clnperez pushed a commit to clnperez/installer that referenced this pull request Sep 2, 2021
initial install-config.yaml generation via the user survey
clnperez pushed a commit to clnperez/installer that referenced this pull request Sep 2, 2021
initial install-config.yaml generation via the user survey
zaneb pushed a commit to zaneb/openshift-installer that referenced this pull request Apr 26, 2022
zaneb pushed a commit to zaneb/openshift-installer that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants