-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DCO: Update Linux Foundation address (to Letterman Drive) #26
Conversation
Can one of the admins verify this patch? |
Hi @wking. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Generated with: $ curl -s https://developercertificate.org >DCO after which I stripped the <pre> tags and everything outside of them.
San Francisco, CA 94110 USA | ||
1 Letterman Drive | ||
Suite D4700 | ||
San Francisco, CA, 94129 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comma is needed between the state and the ZIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comma is needed between the state and the ZIP
This is what came out of curl
ing https://developercertificate.org. With the DCO distributed under verbatim-copies-only terms, I don't think it's worth tuning their content. Maybe submit these suggestions upstream to the LF?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I missed that. this in indeed the content of the hosted document :/
660 York Street, Suite 102, | ||
San Francisco, CA 94110 USA | ||
1 Letterman Drive | ||
Suite D4700 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this line need the building number too? Building D, Suite D4700
? as in https://www.linuxfoundation.org/about/contact/
/lgtm |
@wking: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR had the same operator Instantiate the template e2e-aws into the operator namespace and wait for any pods to complete error as seen in #29. It also had:
|
Use dns discovery in bootkube
* check err on DeleteKeyPair * check err on UpdateStatus
initial install-config.yaml generation via the user survey
initial install-config.yaml generation via the user survey
initial install-config.yaml generation via the user survey
AGENT-66: Use logging
AGENT-66: Use logging
Generated with:
$ curl -s https://developercertificate.org >DCO
after which I stripped the
<pre>
tags and everything outside of them.