[Azure] Change block blob to page blob #3567
Conversation
|
Hi @jomeier. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-ok-to-test
|
Let's see how this experiment goes |
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
|
@LorbusChris Azure tests failed but it seems as if the cluster was created successfully, at least the VMs (and that is what counts here). What's your impression? |
|
if this works, e2e should succeed |
|
/test e2e-azure |
|
Can you please update the commit message to contain details about this change? See: https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#commit-message-format The PR description contains good detail, but was there a motivation for this besides best practices according to docs (e.g. did you see a particular error)? |
|
@patrickdillon this would be mainly to align with OKD. There, manual FCOS image upload is required at the moment, and that only seems to work with Though there might be a good reason that I'm unaware of for RHCOS to use the |
|
@patrickdillon As requested I changed the commit message. |
|
Thank you! Lost the azure test with force push: |
abhinavdahiya
added
the
version/4.6
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
|
/test e2e-azure |
|
@jomeier from the CI logs it looks like |
It seems to be necessary for VHD image files that they have the Azure blob container type 'page' instead of 'block'. That's required for the Azure OKD installer to work.
|
/test e2e-azure |
Yes. I fixed it. Maybe the version of the terraform provider for Azure has changed. |
|
Azure passed 🎉 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
16 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@LorbusChris: |
|
@jomeier yes, but the bot doesn't know that :) I don't have the power to override tests here -- we'll just have to wait patiently. It will merge eventually. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
@jomeier: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-aws-scaleup-rhel7 |
|
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws, ci/prow/e2e-aws-scaleup-rhel7, ci/prow/e2e-ovirt In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi,
Azure VHD files must be of type 'page blob' as described here:
https://stackoverflow.com/questions/29079268/differences-between-azure-block-blob-and-page-blob
https://docs.microsoft.com/en-gb/azure/storage/blobs/storage-blob-pageblob-overview
https://www.ibm.com/support/knowledgecenter/SSPREK_9.0.7/com.ibm.isam.doc/admin/task/tsk_upload_vhd_azure.html
https://docs.microsoft.com/en-gb/azure/lab-services/devtest-lab-upload-vhd-using-storage-explorer
I'm not sure why the master branch of the installer can use block blob mode but I assume it has something todo with the RHCOS image itself being in a Azure container blob storage.
This commit should also work with RHCOS.
We like to test that like discussed with @LorbusChris.
Greetings,
Josef