Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1852722: Bump go-ovirt #3826

Merged
merged 1 commit into from Aug 6, 2020
Merged

Bug 1852722: Bump go-ovirt #3826

merged 1 commit into from Aug 6, 2020

Conversation

gekorob
Copy link
Contributor

@gekorob gekorob commented Jul 1, 2020

Solve an issue related to RHV network parsing

Backport of #3823

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1852722

Signed-off-by: Roberto Ciatti rciatti@redhat.com

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 1, 2020
@openshift-ci-robot
Copy link
Contributor

@gekorob: This pull request references Bugzilla bug 1852722, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead
  • expected dependent Bugzilla bug 1841556 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is CLOSED (UPSTREAM) instead
  • expected dependent Bugzilla bug 1841556 to target a release in 4.6.0, 4.6.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1852722: Bump go-ovirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rgolangh
Copy link
Contributor

rgolangh commented Jul 1, 2020

/lgtm

@gekorob
Copy link
Contributor Author

gekorob commented Jul 1, 2020

/retest

1 similar comment
@gekorob
Copy link
Contributor Author

gekorob commented Jul 1, 2020

/retest

@sandrobonazzola
Copy link

/assign @smarterclayton

@sandrobonazzola
Copy link

/test e2e-aws-scaleup-rhel7

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2020
Bump go-ovirt
5ef3414 
Solve an issue related to RHV network parsing

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1852722

Signed-off-by: Roberto Ciatti <rciatti@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2020
@gekorob
Copy link
Contributor Author

gekorob commented Jul 17, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@gekorob: This pull request references Bugzilla bug 1852722, which is invalid:

  • expected dependent Bugzilla bug 1841556 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED (UPSTREAM) instead
  • expected dependent Bugzilla bug 1841556 to target a release in 4.6.0, 4.6.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gekorob
Copy link
Contributor Author

gekorob commented Jul 17, 2020

@rgolangh @Gal-Zaidman need a check.
I rebase this on release-4.5 branch and solved the conflict about go.mod and go.sum. Did hack/verify-vendor.sh and updated the PR, but the bot it's saying again needs-rebase. What I am missing?

@gekorob
Copy link
Contributor Author

gekorob commented Jul 17, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 17, 2020
@openshift-ci-robot
Copy link
Contributor

@gekorob: This pull request references Bugzilla bug 1852722, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1838559 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1838559 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gekorob
Copy link
Contributor Author

gekorob commented Jul 20, 2020

/retest

@rgolangh
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2d34452 into openshift:release-4.5 Aug 6, 2020
@openshift-ci-robot
Copy link
Contributor

@gekorob: All pull requests linked via external trackers have merged: openshift/installer#3826. Bugzilla bug 1852722 has been moved to the MODIFIED state.

In response to this:

Bug 1852722: Bump go-ovirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@smarterclayton smarterclayton

@rgolangh rgolangh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@gekorob @openshift-ci-robot @rgolangh @sandrobonazzola @abhinavdahiya @openshift-bot @sdodson @smarterclayton @openshift-merge-robot