Option to pass floating IP to ingress port #3855
Conversation
iamemilio
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
/cc @adduarte |
|
will rebase on https://github.com/openshift/installer/pull/3864/files to fix validvaluesfetcher mock |
|
/hold until #3864 |
openshift-ci-robot
added
the
do-not-merge/hold
|
Removed all validations, will add them and docs in a separate pull request due to numerous pending changes to the validations code base. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
iamemilio
force-pushed
the
ingress_fip
branch
2 times, most recently
from
748a2f2
to
c19be45
Compare
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
iamemilio
force-pushed
the
ingress_fip
branch
2 times, most recently
from
fd1cd6e
to
84a8855
Compare
|
/retest |
iamemilio
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
Will squash on merge. Validations and Docs in an upcoming pr to avoid merge conflicts |
| @@ -1313,6 +1318,7 @@ spec: | |||
| - cloud | |||
| - computeFlavor | |||
| - externalNetwork | |||
| - ingressFloatingIP | |||
| - lbFloatingIP | |||
There was a problem hiding this comment.
this should be renamed as APIFloatingIP then, right?
There was a problem hiding this comment.
Not sure we can simply rename it, we should instead deprecate lbFloatingIP in favor of APIFloatingIP.
There was a problem hiding this comment.
Yeah, I think that should really be a separate PR
|
@iamemilio good to squash? |
To make the user experience more cohesive, we are adding this feature to allow users to pass a floating IP to be attached to the ingress port. This mirrors the way users add the floating ip for the API port.
|
/approve |
|
/assign @sdodson pls review/approve when you can |
|
/assign @sdodson |
|
/approve |
|
Will this be backported to the lower version? |
This is planned for 4.6, with no intention to backport to previous releases. We try to avoid backporting features unless there is a strong reason for it (customer case for instance). |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, sdodson, wjiangjay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@iamemilio: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Since openshift#3855, the installer is able to attach the `ingressFloatingIP` specified in the `install-config.yaml` to the ingress-port. Update the documentation to reflect the change.
Since openshift#3855, the installer is able to attach the `ingressFloatingIP` specified in the `install-config.yaml` to the ingress-port. Update the documentation to reflect the change.
Since openshift#3855, the installer is able to attach the `ingressFloatingIP` specified in the `install-config.yaml` to the ingress-port. Update the documentation to reflect the change.
Customers have requested a more consistent experience for floating IPs in the installer, with a preference for how the loadbalancer FIP is implemented. To support this, we created an option for passing a floating ip for the ingress port that is identical in usage to the loadbalancer/api port implementation.