Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1877676: OpenStack: Refresh documentation about ingress FIP #4059

Merged
merged 1 commit into from Sep 11, 2020
Merged

Bug 1877676: OpenStack: Refresh documentation about ingress FIP #4059

merged 1 commit into from Sep 11, 2020

Conversation

mandre
Copy link
Member

@mandre mandre commented Aug 17, 2020

Since #3855, the installer is
able to attach the ingressFloatingIP specified in the
install-config.yaml to the ingress-port. Update the documentation to
reflect the change.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 17, 2020 •
edited

@mandre: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-workers-rhel7 36fcc9e link /test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

maxwelldb
maxwelldb reviewed Aug 20, 2020
View reviewed changes
docs/user/openstack/README.md Outdated

To make the OpenShift Ingress access available (this includes logging into the deployed cluster), you will need to attach the Ingress floating IP to the `ingress-port` after the cluster is created.
If not, you can always attach the Ingress floating IP to the `ingress-port` after the cluster is created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mandre Would you say that providing ingressFloatingIP at installation is preferred to providing the FIP post-installation, now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say so, this makes it for a more streamlined installation flow if you add the Ingress FIP to install-config.yaml right from the start.

The setting is not exposed via the wizard, but it's not a big issue since you can still create the Ingress FIP post-install and attach it to the ingress port as before.

@mandre mandre changed the title OpenStack: Refresh documentation about ingress FIP Bug 1877676: OpenStack: Refresh documentation about ingress FIP Sep 10, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 10, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Bugzilla bug 1877676, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1877676: OpenStack: Refresh documentation about ingress FIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fedosin
Fedosin reviewed Sep 10, 2020
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2020
@pierreprinetti
Copy link
Member

/approve
/hold

@mandre
Feel free to cancel the hold if you choose not to address my comment; it's just a nit.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@mandre
OpenStack: Refresh documentation about ingress FIP
d9bd956 
Since openshift#3855, the installer is
able to attach the `ingressFloatingIP` specified in the
`install-config.yaml` to the ingress-port. Update the documentation to
reflect the change.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@pierreprinetti
Copy link
Member

/lgtm
/hold cancel
/label platform/openstack
/honk

@openshift-ci-robot
Copy link
Contributor

@pierreprinetti:
goose image

In response to this:

/lgtm
/hold cancel
/label platform/openstack
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added platform/openstack and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 11, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2876582 into openshift:master Sep 11, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: All pull requests linked via external trackers have merged:

Bugzilla bug 1877676 has been moved to the MODIFIED state.

In response to this:

Bug 1877676: OpenStack: Refresh documentation about ingress FIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre mandre deleted the ingress-fip-doc branch September 17, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierreprinetti pierreprinetti pierreprinetti left review comments

@Fedosin Fedosin Fedosin left review comments

@maxwelldb maxwelldb maxwelldb left review comments

@iamemilio iamemilio Awaiting requested review from iamemilio

Assignees

@pierreprinetti pierreprinetti

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mandre @openshift-ci-robot @pierreprinetti @Fedosin @maxwelldb @openshift-merge-robot