OpenStack: fix runtime error with machine pool validation #3915
Conversation
The recent validations refactoring [1] caused the installer to panic with nil pointer deference when running with an install-config.yaml where the `controlPlane.platform.openstack` struct was unset. This wasn't caught in CI since we do set the struct. [1] openshift#3864
|
Unit tests would have helped catching this error, I'm going to write some. |
|
/retest |
|
Restoring the tests that were removed in #3864 would take too much time, let's merge this bugfix to unblock CI and add the unit tests later. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@mandre: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
The recent validations refactoring [1] caused the installer to panic with
nil pointer deference when running with an install-config.yaml where the
controlPlane.platform.openstackstruct was unset.This wasn't caught in CI since we do set the struct.
[1] #3864