Bug 1862209: types/aws: validate Name and kubernetes.io/clustername/* keys are not allowed

[abhinavdahiya]

Allowing these values as user defined tags causes problems defined in https://bugzilla.redhat.com/show_bug.cgi?id=1862209

[openshift-ci-robot]

@abhinavdahiya: This pull request references Bugzilla bug 1862209, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1862209: types/aws: validate Name and kubernetes.io/clustername/* keys are not allowed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jstuever]

/lgtm

[michaelgugino]

/lgtm

[michaelgugino]

For posterity, here is the corresponding case in the machine-api AWS provider: openshift/cluster-api-provider-aws#343

[abhinavdahiya]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, michaelgugino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/types/aws/OWNERS [abhinavdahiya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@abhinavdahiya: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-libvirt	3a6259e	link	/test e2e-libvirt
ci/prow/e2e-crc	3a6259e	link	/test e2e-crc
ci/prow/e2e-ovirt	3a6259e	link	/test e2e-ovirt
ci/prow/e2e-openstack	3a6259e	link	/test e2e-openstack
ci/prow/e2e-metal-ipi	3a6259e	link	/test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@abhinavdahiya: All pull requests linked via external trackers have merged: openshift/installer#4008. Bugzilla bug 1862209 has been moved to the MODIFIED state.

In response to this:

Bug 1862209: types/aws: validate Name and kubernetes.io/clustername/* keys are not allowed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.