-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1867165: baremetal: allow configuring bootstrap mac addresses #4052
Conversation
/label platform/baremetal |
@stbenjam: This pull request references Bugzilla bug 1867165, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Also IMO this is not a change that we should be doing in code freeze-reduce bugs cycle. The attached bug is not a bug rather a feature request and should probably be prioritized through our JIRA processes. |
The platform is unusable in some environments without this which IMHO makes it a bug -- accessing hardware BMC's (baseboard management controllers) is something you want to restrict and you can't without being able to assign a specific IP to the bootstrap. This is even more important in light of #3929, as a user installing without a provisioning network no longer has a dedicated, private provisioning network. /cc @celebdor |
I agree, this is a usability bug since we know the installer won't work in environments that don't allow DHCP pools without explicit reservations. |
/test e2e-metal-ipi |
/approve |
ac9246d
to
2f1f5ab
Compare
/refresh |
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
/lgtm |
/approve |
This needs an installer team member to approve, as we're touching a few files outside our directories (e.g., data/data/install.openshift.io_installconfigs.yaml) /assign @abhinavdahiya @staebler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. I just have a couple nits.
If users are unable to define the mac addresses for the bootstrap host, they won't be able to set static DHCP reservations for the host. Many corporate environments do not allow unrestricted DHCP. Co-authored-by: Matthew Staebler <staebler@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, hardys, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@stbenjam: All pull requests linked via external trackers have merged: Bugzilla bug 1867165 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In openshift#4052 we added interfaces to control the MAC addresses for the NICs in the bootstrap VM, so that in environments where DHCP pools are not allowed, a static reservation can be made. Unfortunately that doesn't work in ipv6 environments currently, because NetworkManager needs a specific configuration similar to that applied via the MCO[1] for cluster hosts to ensure the generated client-ID is derived from the MAC and predictable. [1] https://github.com/openshift/machine-config-operator/blob/master/templates/common/on-prem/files/NetworkManager-onprem.conf.yaml
In openshift#4052 we added interfaces to control the MAC addresses for the NICs in the bootstrap VM, so that in environments where DHCP pools are not allowed, a static reservation can be made. Unfortunately that doesn't work in ipv6 environments currently, because NetworkManager needs a specific configuration similar to that applied via the MCO[1] for cluster hosts to ensure the generated client-ID is derived from the MAC and predictable. [1] https://github.com/openshift/machine-config-operator/blob/master/templates/common/on-prem/files/NetworkManager-onprem.conf.yaml
In openshift#4052 we added interfaces to control the MAC addresses for the NICs in the bootstrap VM, so that in environments where DHCP pools are not allowed, a static reservation can be made. Unfortunately that doesn't work in ipv6 environments currently, because NetworkManager needs a specific configuration similar to that applied via the MCO[1] for cluster hosts to ensure the generated client-ID is derived from the MAC and predictable. [1] https://github.com/openshift/machine-config-operator/blob/master/templates/common/on-prem/files/NetworkManager-onprem.conf.yaml
If users are unable to define the mac addresses for the bootstrap host,
they won't be able to set static DHCP reservations for the host. Many
corporate environments do not allow unrestricted DHCP.