Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1868748: baremetal: rename JSON field for ClusterProvisioningIP #4053

Merged
merged 1 commit into from Dec 5, 2020
Merged

Bug 1868748: baremetal: rename JSON field for ClusterProvisioningIP #4053

merged 1 commit into from Dec 5, 2020

Conversation

stbenjam
Copy link
Member

The ClusterProvisioningIP field in the baremetal platform had an
incorrect JSON annotation for serialization/deserialization, using
"provisioningHostIP" instead of "clusterProvisioningIP." This name is
incorrect and doesn't adequately reflect it's purpose. This field is
the IP used in the cluster for provisioning.

This commit deprecates the old JSON field, and uses the correct JSON
annotation for ClusterProvisioningIP.

@stbenjam
Copy link
Member Author

/label platform/baremetal

@openshift-ci-robot openshift-ci-robot added the platform/baremetal IPI bare metal hosts platform label Aug 13, 2020
@stbenjam stbenjam changed the title baremetal: rename JSON field for ClusterProvisioningIP Bug 1868748: baremetal: rename JSON field for ClusterProvisioningIP Aug 13, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 13, 2020
@openshift-ci-robot
Copy link
Contributor

@stbenjam: This pull request references Bugzilla bug 1868748, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1868748: baremetal: rename JSON field for ClusterProvisioningIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@stbenjam: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/gofmt b98d29a link /test gofmt
ci/prow/e2e-ovirt b98d29a link /test e2e-ovirt
ci/prow/e2e-aws-workers-rhel7 b98d29a link /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-fips b98d29a link /test e2e-aws-fips
ci/prow/e2e-aws b98d29a link /test e2e-aws
ci/prow/e2e-libvirt b98d29a link /test e2e-libvirt
ci/prow/e2e-crc b98d29a link /test e2e-crc
ci/prow/e2e-aws-upgrade b98d29a link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Contributor

Also IMO this is not a change that we should be doing in code freeze-reduce bugs cycle. The attached bug is not a bug rather a feature request.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2020
@stbenjam
Copy link
Member Author

Also IMO this is not a change that we should be doing in code freeze-reduce bugs cycle. The attached bug is not a bug rather a feature request.

Sure, we can certainly wait for this to go in 4.7, it's just a minor annoyance.

@hardys hardys mentioned this pull request Sep 7, 2020
Closed
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2020
@hardys
Copy link
Contributor

hardys commented Nov 16, 2020

/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 16, 2020
@hardys
Copy link
Contributor

hardys commented Nov 24, 2020

Hey @stbenjam this needs a rebase, could you update then we can hopefully land it in time for 4.7?

@stbenjam
Copy link
Member Author

/retest

@stbenjam
Copy link
Member Author

I've updated this PR

/assign @hardys

Could you take a look? Thanks!

@stbenjam
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Nov 30, 2020
@openshift-ci-robot
Copy link
Contributor

@stbenjam: This pull request references Bugzilla bug 1868748, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hardys
Copy link
Contributor

hardys commented Dec 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@staebler staebler mentioned this pull request Dec 1, 2020
Merged
@stbenjam
baremetal: rename JSON field for ClusterProvisioningIP
038e8b9 
The ClusterProvisioningIP field in the baremetal platform had an
incorrect JSON annotation for serialization/deserialization, using
"provisioningHostIP" instead of "clusterProvisioningIP." This name is
incorrect and doesn't adequately reflect it's purpose. This field is
the IP used in the cluster for provisioning.

This commit deprecates the old JSON field, and uses the correct JSON
annotation for ClusterProvisioningIP.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@stbenjam
Copy link
Member Author

stbenjam commented Dec 2, 2020

#4429 introduced a conflict. Rebased.

@hardys
Copy link
Contributor

hardys commented Dec 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@stbenjam
Copy link
Member Author

stbenjam commented Dec 3, 2020

/test e2e-aws
/skip

@stbenjam
Copy link
Member Author

stbenjam commented Dec 4, 2020

/test e2e-aws

@stbenjam
Copy link
Member Author

stbenjam commented Dec 4, 2020

/test e2e-aws
/skip

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 4, 2020 •
edited

@stbenjam: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-workers-rhel7 038e8b9 link /test e2e-aws-workers-rhel7
ci/prow/e2e-libvirt 038e8b9 link /test e2e-libvirt
ci/prow/e2e-crc 038e8b9 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam
Copy link
Member Author

stbenjam commented Dec 4, 2020

/test e2e-aws

🙏

@openshift-merge-robot openshift-merge-robot merged commit e8c9a2f into openshift:master Dec 5, 2020
@openshift-ci-robot
Copy link
Contributor

@stbenjam: All pull requests linked via external trackers have merged:

Bugzilla bug 1868748 has been moved to the MODIFIED state.

In response to this:

Bug 1868748: baremetal: rename JSON field for ClusterProvisioningIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@markmc markmc Awaiting requested review from markmc

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@hardys hardys

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. platform/baremetal IPI bare metal hosts platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@stbenjam @openshift-ci-robot @abhinavdahiya @openshift-bot @hardys @openshift-merge-robot