baremetal: make cluster provisioning IP optional #4429
Conversation
This makes the cluster provisioning IP optional when the provisioning network is disabled. If no provisioning IP is provided, then we use the host IP of the node we're running on.
|
/label platform/baremetal |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
| // If set, ensure clusterProvisioningIP is in one of the machine networks | ||
| if p.ClusterProvisioningIP != "" { | ||
| if err := validateIPinMachineCIDR(p.ClusterProvisioningIP, n); err != nil { | ||
| allErrs = append(allErrs, field.Invalid(fldPath.Child("clusterProvisioningIP"), p.ClusterProvisioningIP, fmt.Sprintf("provisioning network is disabled, %s", err.Error()))) |
There was a problem hiding this comment.
Understanding that this is existing code, this still seems like a good time to fix this.
| allErrs = append(allErrs, field.Invalid(fldPath.Child("clusterProvisioningIP"), p.ClusterProvisioningIP, fmt.Sprintf("provisioning network is disabled, %s", err.Error()))) | |
| allErrs = append(allErrs, field.Invalid(fldPath.Child("provisioningHostIP"), p.ClusterProvisioningIP, fmt.Sprintf("provisioning network is disabled, %s", err.Error()))) |
There was a problem hiding this comment.
Or I suppose it will conflict with the changes made in #4053, and that other PR is a better place to make the field name consistent.
There was a problem hiding this comment.
Yea good point, I think when one lands the other will have a conflict so I'll adjust the one that doesn't merge.
|
/retest Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This makes the cluster provisioning IP optional when the provisioning
network is disabled. If no provisioning IP is provided, then we use
the host IP of the node we're running on.
This is dependent on the work in openshift/cluster-baremetal-operator#73
and openshift/cluster-baremetal-operator#76