[FCOS] Rebase Sep 10 #4158
Merged
[FCOS] Rebase Sep 10 #4158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling terraform destroy the tmpVM disk is not removed from the engine. This is because the tmp VM unlike any other VM is not created from an oVirt template, and we create a separate disk for it with ovirt_image_transfer. This PR removes the disk resource when calling destroy Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
…data config This PR is autogenerated by the [ocp-build-data-enforcer][1]. It updates the baseimages in the Dockerfile used for promotion in order to ensure it matches the configuration in the [ocp-build-data repository][2] used for producing release artifacts. If you believe the content of this PR is incorrect, please contact the dptp team in #forum-testplatform. [1]: https://github.com/openshift/ci-tools/tree/master/cmd/ocp-build-data-enforcer [2]: https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images
…h ocp-build-data config This PR is autogenerated by the [ocp-build-data-enforcer][1]. It updates the baseimages in the Dockerfile used for promotion in order to ensure it matches the configuration in the [ocp-build-data repository][2] used for producing release artifacts. If you believe the content of this PR is incorrect, please contact the dptp team in #forum-testplatform. [1]: https://github.com/openshift/ci-tools/tree/master/cmd/ocp-build-data-enforcer [2]: https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images
…data config This PR is autogenerated by the [ocp-build-data-enforcer][1]. It updates the baseimages in the Dockerfile used for promotion in order to ensure it matches the configuration in the [ocp-build-data repository][2] used for producing release artifacts. If you believe the content of this PR is incorrect, please contact the dptp team in #forum-testplatform. [1]: https://github.com/openshift/ci-tools/tree/master/cmd/ocp-build-data-enforcer [2]: https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images
Do not assume that the `storage` is present in the Ignition file generated by the Installer.
US Govcloud and China partitions do not allow copying AMI from commercial region us-east-1. Therefore the users need to provide the AMI for control plane and compute.
Managed policies could be attached after initial installation. In order to delete the IAM roles created during install, these custom managed polices should be detached allowing the role to be deleted.
This will increase install speed and reduce retries by creating namespace annotations required for SCC.
Just like openshift#4095 but for multi-arch
Trailing commas are not allowed in JSON.
There are no longer any etcd records in our DNS, and some other details of how baremetal DNS works have changed since this was originally written. This updates everything to reflect the current reality.
Pass the root device hints given by the user in the install-config to the BareMetalHost resources created in the cluster. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
In RHEL8 we need to use explicitly python3 command Signed-off-by: Roberto Ciatti <rciatti@redhat.com>
Moving Network Requirements upper to keep all the requirements at the beginning
Now, during install config generation, we cannot set lbFloatingIP value because there is a variable redeclaration in the code. This patch removes nested variable declaration, which allows the installer to assign the value to the right variable.
…ests and openshift directory to avoid unwanted file types Since all the files from manifests/ and openshift/ directories are candidate for k8s resources to be pushed by the installer to the cluster when bootstrapping, having non yaml/json files causes failure on reading.
In some environments Glance cannot return bootstrap ignition config in time (10 seconds), and users see timeout errors. To prevent it this commit increases the default timeout to two minutes.
… ingressVIP addresses Added required documentation describing the roles and requirements of apiVIP and ingressVIP fields in install-config.yaml
This change allows the haproxy.service to restart cleanly by removing the haproxy pod on ExecStop.
The example script to remove apiVIP and ingressVIP attributes from the `install-config.yaml` file used an invalid python keyword. This commit fixes it.
Because the script is passed on the command line to the python interpreter, it's enclosed in simple quotes. As a consequence, we should use double quotes for strings otherwise we get a SyntaxError.
Semicolons in python are only needed in case we have multiple statements on the same line. This is not the case in our scripts.
|
/uncc markmc Fedosin |
|
/override ci/prow/e2e-aws |
|
@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LorbusChris The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to pass cluster-policy-controller image