Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1880443: allow providing client options when generating OpenStack MachineSets #4196

Merged
merged 1 commit into from Oct 23, 2020
Merged

Bug 1880443: allow providing client options when generating OpenStack MachineSets #4196

merged 1 commit into from Oct 23, 2020

Conversation

joelddiaz
Copy link
Contributor

Hive calls into the installer's functions for converting MachinePools to MachineSets.
As Hive can be reconciling multiple cluster states simultaneously, we cannot rely on setting shared OS_* environment variables.
Extend the installer's functions for OpenStack to allow providing custom versions of reading in the OpenStack credentials.

@joelddiaz joelddiaz mentioned this pull request Sep 17, 2020
Merged
3 tasks
@joelddiaz joelddiaz changed the title allow providing client options when generating OpenStack MachineSets Bug 1880443: allow providing client options when generating OpenStack MachineSets Sep 18, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Sep 18, 2020
@openshift-ci-robot
Copy link
Contributor

@joelddiaz: This pull request references Bugzilla bug 1880443, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1880443: allow providing client options when generating OpenStack MachineSets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 18, 2020
@jstuever
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Sep 24, 2020
@openshift-ci-robot
Copy link
Contributor

@jstuever: This pull request references Bugzilla bug 1880443, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 24, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2020
@joelddiaz
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 6, 2020
@openshift-ci-robot
Copy link
Contributor

@joelddiaz: This pull request references Bugzilla bug 1880443, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 6, 2020
@jstuever
Copy link
Contributor

jstuever commented Oct 9, 2020

/retest

@jstuever
Copy link
Contributor

jstuever commented Oct 9, 2020

/uncc
/cc @mandre

@openshift-ci-robot openshift-ci-robot requested review from mandre and removed request for jstuever October 9, 2020 16:34
@joelddiaz
Copy link
Contributor Author

/retest

@joelddiaz
Copy link
Contributor Author

@mandre do the changes in the PR look acceptable? The hive team is currently waiting on this (or some similar changes) so that we can fix generating MachineSets with hive on OpenStack-managed clusters.

mandre
mandre approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2020
@mandre
Copy link
Member

mandre commented Oct 12, 2020

/approve

@joelddiaz
Copy link
Contributor Author

/retest

@joelddiaz
Copy link
Contributor Author

/test e2e-libvirt

1 similar comment
@joelddiaz
Copy link
Contributor Author

/test e2e-libvirt

@openshift-ci-robot
Copy link
Contributor

@joelddiaz: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 1800a06 link /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joelddiaz
Copy link
Contributor Author

/test e2e-libvirt

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b3970d8 into openshift:master Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

@joelddiaz: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1880443 has not been moved to the MODIFIED state.

In response to this:

Bug 1880443: allow providing client options when generating OpenStack MachineSets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staebler staebler staebler left review comments

@mandre mandre mandre approved these changes

@adduarte adduarte Awaiting requested review from adduarte

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@joelddiaz @openshift-ci-robot @jstuever @mandre @abhinavdahiya @openshift-bot @staebler @openshift-merge-robot