-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1880443: allow providing client options when generating OpenStack MachineSets #4196
Bug 1880443: allow providing client options when generating OpenStack MachineSets #4196
Conversation
11ede67
to
2fb2cc6
Compare
@joelddiaz: This pull request references Bugzilla bug 1880443, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@jstuever: This pull request references Bugzilla bug 1880443, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2fb2cc6
to
1800a06
Compare
/bugzilla refresh |
@joelddiaz: This pull request references Bugzilla bug 1880443, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/uncc |
/retest |
@mandre do the changes in the PR look acceptable? The hive team is currently waiting on this (or some similar changes) so that we can fix generating MachineSets with hive on OpenStack-managed clusters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
/retest |
/test e2e-libvirt |
1 similar comment
/test e2e-libvirt |
@joelddiaz: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-libvirt |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@joelddiaz: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1880443 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hive calls into the installer's functions for converting MachinePools to MachineSets.
As Hive can be reconciling multiple cluster states simultaneously, we cannot rely on setting shared
OS_*
environment variables.Extend the installer's functions for OpenStack to allow providing custom versions of reading in the OpenStack credentials.