Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1885624: vsphere - add delay if resolv.conf is not available; wait for dhcp #4246

Merged
merged 2 commits into from
Oct 8, 2020
Merged

[release-4.6] Bug 1885624: vsphere - add delay if resolv.conf is not available; wait for dhcp #4246

merged 2 commits into from
Oct 8, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #4237

/assign jcpowermac

@jcpowermac
vsphere - add down as network interface status to run prepender
57068ff 
Randomly the resolver will not be configured with 127.0.0.1 causing
bootstrap failure, adding status `down` to see if it improves.
@jcpowermac
Use MCO baremetal template as an example to wait for NetworkManager t…
a890990 
…o wait for nameserver population before adding loopback
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 7, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1884435 with correct target release. Retitling PR to link to clone:
/retitle [release-4.6] Bug 1885624: vsphere - add delay if resolv.conf is not available; wait for dhcp

In response to this:

[release-4.6] Bug 1884435: vsphere - add delay if resolv.conf is not available; wait for dhcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1884435: vsphere - add delay if resolv.conf is not available; wait for dhcp [release-4.6] Bug 1885624: vsphere - add delay if resolv.conf is not available; wait for dhcp Oct 7, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 7, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1885624, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1884435 is in the state MODIFIED, which is one of the valid states (MODIFIED, VERIFIED)
  • dependent Bugzilla bug 1884435 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

[release-4.6] Bug 1885624: vsphere - add delay if resolv.conf is not available; wait for dhcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcpowermac
Copy link
Contributor

@celebdor here is the CP for 4.6

/assign @mtnbikenc

/test e2e-vsphere

@mtnbikenc
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtnbikenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@knobunc knobunc added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Oct 7, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@knobunc
Copy link

knobunc commented Oct 8, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Oct 8, 2020

The Azure UPI failure is also happening in the 4.6 release job, so this change does not create that problem.
https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-e2e-azure-4.6/1314172796762329088
Multiple bugs on the same as well, though one is a dupe of the other and that's been CLOSED DEFERRED.
https://bugzilla.redhat.com/show_bug.cgi?id=1779375
https://bugzilla.redhat.com/show_bug.cgi?id=1878009
/override ci/prow/e2e-azure-upi

/override ci/prow/e2e-crc
never passes

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-azure-upi, ci/prow/e2e-crc

In response to this:

The Azure UPI failure is also happening in the 4.6 release job, so this change does not create that problem.
https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-e2e-azure-4.6/1314172796762329088
Multiple bugs on the same as well, though one is a dupe of the other and that's been CLOSED DEFERRED.
https://bugzilla.redhat.com/show_bug.cgi?id=1779375
https://bugzilla.redhat.com/show_bug.cgi?id=1878009
/override ci/prow/e2e-azure-upi

/override ci/prow/e2e-crc
never passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Oct 8, 2020

/override ci/prow/e2e-gcp-upi-xpn
Never passes, not relevant.

vsphere relevant tests have passed.

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-gcp-upi-xpn

In response to this:

/override ci/prow/e2e-gcp-upi-xpn
Never passes, not relevant.

vsphere relevant tests have passed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Oct 8, 2020

/override ci/prow/e2e-azure-upi
irrelevant
/override ci/prow/e2e-gcp-upi-xpn
irrelevant
/override ci/prow/e2e-crc
permanent failure and irrelevant

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-azure-upi, ci/prow/e2e-crc, ci/prow/e2e-gcp-upi-xpn

In response to this:

/override ci/prow/e2e-azure-upi
irrelevant
/override ci/prow/e2e-gcp-upi-xpn
irrelevant
/override ci/prow/e2e-crc
permanent failure and irrelevant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt a890990 link /test e2e-libvirt
ci/prow/e2e-gcp-upi-xpn a890990 link /test e2e-gcp-upi-xpn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ebdbda5 into openshift:release-4.6 Oct 8, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1885624 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1885624: vsphere - add delay if resolv.conf is not available; wait for dhcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnbikenc mtnbikenc mtnbikenc approved these changes

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@jstuever jstuever Awaiting requested review from jstuever

Assignees

@jcpowermac jcpowermac

@mtnbikenc mtnbikenc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @jcpowermac @mtnbikenc @openshift-bot @sdodson @knobunc @openshift-merge-robot