pkg/asset/cluster/aws: switch to ec2 tagging API

[patrickdillon]

ResourceTagging API is not available for C2S use case. This switches from tagging shared subnets with ResourceTagging API to EC2 API.

CORS-1580

[patrickdillon]

/test e2e-aws-shared-vpc

Need to manually test in shared VPC environment, but wanted to make use of CI while reminding myself how to setup shared env.

[patrickdillon]

/test e2e-aws-shared-vpc

[patrickdillon]

/test e2e-aws-shared-vpc

[patrickdillon]

/retest

I can confirm from testing tag is being added:

$ aws ec2 describe-subnets --subnet-ids subnet-07b973022c355d818
               [...]
                {
                    "Key": "kubernetes.io/cluster/padillon-hcvmv",
                    "Value": "shared"
                },
              [...]

[patrickdillon]

local testing succeeded. I think this is ready for review.

[patrickdillon]

/test e2e-aws-shared-vpc

Install succeeded. E2E failed with:

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/4356/pull-ci-openshift-installer-master-e2e-aws-shared-vpc/1325851954550673408#1:build-log.txt%3A7754

[staebler]

/approve
/lgtm

Holding to wait for the shared-VPC e2e tests to pass.
/hold

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/asset/cluster/aws/OWNERS [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[patrickdillon]

/test e2e-aws-shared-vpc

[patrickdillon]

shared-vpc passed! for the first time ever!

/meowvie

[openshift-ci-robot]

@patrickdillon:

In response to this:

shared-vpc passed! for the first time ever!

/meowvie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[staebler]

/hold cancel

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-merge-robot]

@patrickdillon: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-crc	27d34ad	link	/test e2e-crc
ci/prow/e2e-ovirt	27d34ad	link	/test e2e-ovirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.