-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/asset/cluster/aws: switch to ec2 tagging API #4356
pkg/asset/cluster/aws: switch to ec2 tagging API #4356
Conversation
ResourceTagging API is not available for C2S use case. This switches from tagging shared subnets with ResourceTagging API to EC2 API.
/test e2e-aws-shared-vpc Need to manually test in shared VPC environment, but wanted to make use of CI while reminding myself how to setup shared env. |
/test e2e-aws-shared-vpc |
1 similar comment
/test e2e-aws-shared-vpc |
/retest I can confirm from testing tag is being added:
|
local testing succeeded. I think this is ready for review. |
/test e2e-aws-shared-vpc Install succeeded. E2E failed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Holding to wait for the shared-VPC e2e tests to pass.
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws-shared-vpc |
shared-vpc passed! for the first time ever! /meowvie |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
ResourceTagging API is not available for C2S use case. This switches from tagging shared subnets with ResourceTagging API to EC2 API.
CORS-1580