Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baremetal: Add ironic logwatch containers #4437

Merged
merged 1 commit into from Dec 3, 2020
Merged

baremetal: Add ironic logwatch containers #4437

merged 1 commit into from Dec 3, 2020

Conversation

hardys
Copy link
Contributor

@hardys hardys commented Dec 1, 2020

A new entrypoint has been added to the ironic containers
that watches for deploy ramdisk logs in the shared volume
and exposes them via the regular podman logs output.

openshift/ironic-inspector-image#47
openshift/ironic-image#121

This should make it easier for users debugging as they no longer
need to exec into the containers and have knowledge of the
internal logfile location.

@hardys
Copy link
Contributor Author

hardys commented Dec 1, 2020

/label platform/baremetal
/cc @stbenjam

@openshift-ci-robot openshift-ci-robot added the platform/baremetal IPI bare metal hosts platform label Dec 1, 2020
@stbenjam stbenjam mentioned this pull request Dec 1, 2020
Merged
@stbenjam
Copy link
Member

stbenjam commented Dec 2, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
baremetal: Add ironic logwatch containers
91e0a64 
A new entrypoint has been added to the ironic containers
that watches for deploy ramdisk logs in the shared volume
and exposes them via the regular podman logs output.

openshift/ironic-inspector-image#47
openshift/ironic-image#121

This should make it easier for users debugging as they no longer
need to exec into the containers and have knowledge of the
internal logfile location.
kirankt
kirankt approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@kirankt kirankt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kirankt, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@stbenjam
Copy link
Member

stbenjam commented Dec 2, 2020

/skip

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 3, 2020 •
edited

@hardys: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc 91e0a64 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8f9eb7c into openshift:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stbenjam stbenjam stbenjam left review comments

@kirankt kirankt kirankt approved these changes

@markmc markmc Awaiting requested review from markmc

@russellb russellb Awaiting requested review from russellb

Assignees

@kirankt kirankt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/baremetal IPI bare metal hosts platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hardys @stbenjam @openshift-ci-robot @openshift-bot @openshift-merge-robot @kirankt