Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ironic log watch cherry-pick #121

Merged
merged 2 commits into from Nov 16, 2020

Conversation

akiselev1
Copy link

No description provided.

@stbenjam
Copy link
Member

/approve
/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akiselev1, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 13, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@stbenjam
Copy link
Member

/override ci/prow/e2e-metal-ipi-virtualmedia

@openshift-ci-robot
Copy link

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-metal-ipi-virtualmedia

In response to this:

/override ci/prow/e2e-metal-ipi-virtualmedia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@stbenjam
Copy link
Member

/override ci/prow/e2e-metal-ipi-virtualmedia

@openshift-ci-robot
Copy link

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-metal-ipi-virtualmedia

In response to this:

/override ci/prow/e2e-metal-ipi-virtualmedia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit b208c58 into openshift:master Nov 16, 2020
andfasano pushed a commit to andfasano/ironic-image that referenced this pull request Nov 18, 2020
Remove outdated instruction related to log files
hardys pushed a commit to hardys/installer that referenced this pull request Dec 1, 2020
A new entrypoint has been added to the ironic containers
that watches for deploy ramdisk logs in the shared volume
and exposes them via the regular podman logs output.

openshift/ironic-inspector-image#47
openshift/ironic-image#121

This should make it easier for users debugging as they no longer
need to exec into the containers and have knowledge of the
internal logfile location.
hardys pushed a commit to hardys/installer that referenced this pull request Dec 2, 2020
A new entrypoint has been added to the ironic containers
that watches for deploy ramdisk logs in the shared volume
and exposes them via the regular podman logs output.

openshift/ironic-inspector-image#47
openshift/ironic-image#121

This should make it easier for users debugging as they no longer
need to exec into the containers and have knowledge of the
internal logfile location.
michaelgugino pushed a commit to mgugino-upstream-stage/installer that referenced this pull request Dec 4, 2020
A new entrypoint has been added to the ironic containers
that watches for deploy ramdisk logs in the shared volume
and exposes them via the regular podman logs output.

openshift/ironic-inspector-image#47
openshift/ironic-image#121

This should make it easier for users debugging as they no longer
need to exec into the containers and have knowledge of the
internal logfile location.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants