Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1909978: update ignore-volume-az documentation #4617

Merged
merged 1 commit into from Feb 4, 2021
Merged

Bug 1909978: update ignore-volume-az documentation #4617

merged 1 commit into from Feb 4, 2021

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Feb 4, 2021 •
edited

Now in the documentation we assume that the Cinder AZ is always called "nova". This commit replaces the hardcoded "nova" string with "<Cinder_AZ>", which then will be changed by users to the real Cinder AZ name.

/label platform/openstack

@Fedosin
Bug 1909978: update ignore-volume-az documentation
018be64 
Now in the documentation we assume that the Cinder AZ is always
called "nova". This commit replaces the hardcoded "nova" string with
"<Cinder_AZ>", which then will be changed by users to the real
Cinder AZ name.
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Feb 4, 2021
@openshift-ci-robot
Copy link
Contributor

@Fedosin: This pull request references Bugzilla bug 1909978, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1909978: update ignore-volume-az documentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 4, 2021
@openshift-ci-robot
Copy link
Contributor

@Fedosin: This pull request references Bugzilla bug 1909978, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1909978: update ignore-volume-az documentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 4, 2021
mandre
mandre reviewed Feb 4, 2021
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-merge-robot openshift-merge-robot merged commit 6e859d5 into openshift:master Feb 4, 2021
@openshift-ci-robot
Copy link
Contributor

@Fedosin: All pull requests linked via external trackers have merged:

Bugzilla bug 1909978 has been moved to the MODIFIED state.

In response to this:

Bug 1909978: update ignore-volume-az documentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@EmilienM EmilienM Awaiting requested review from EmilienM

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

Assignees

@mandre mandre

@pierreprinetti pierreprinetti

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Fedosin @openshift-ci-robot @pierreprinetti @mandre @openshift-merge-robot