-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ovirt]: Removed '0' from machineset name #4723
[ovirt]: Removed '0' from machineset name #4723
Conversation
worker nodes created by the installer have number '0' suffixed Fixes bz/1817954
Hi @apoorvajagtap. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Hi @apoorvajagtap thank you very much for your contribution. |
/retest |
make sense |
/retest |
2 similar comments
/retest |
/retest |
/approve |
/retest Please review the full test history for this PR and help us cut down flakes. |
@apoorvajagtap I have now approved this PR and the bot will "punch it through", no need to run retests manually. Thank you again for your contribution, this one was on our list but we haven't gotten around to do it. From the feedback we got there are quite a few folks who will appreciate the better naming. :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: janoszen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the help @janoszen. I have been following that BZ for a long time and thought to give it a try. I hope it is helpful. :) |
Awesome work, thanks for tracking it down. |
Glad to do that! |
@apoorvajagtap: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Thank you very much @apoorvajagtap for your patch! |
Happy to contribute @sandrobonazzola :) |
Machineset: Removed '0' from the name
worker nodes created by the installer have number '0' suffixed
Fixes bz-1817954