Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ovirt]: Removed '0' from machineset name #4723

Merged

Conversation

apoorvajagtap
Copy link

Machineset: Removed '0' from the name

worker nodes created by the installer have number '0' suffixed

Fixes bz-1817954

worker nodes created by the installer have number '0' suffixed

Fixes bz/1817954
@openshift-ci-robot openshift-ci-robot requested review from a user and rgolangh March 8, 2021 15:01
@openshift-ci-robot
Copy link
Contributor

Hi @apoorvajagtap. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 8, 2021
@ghost
Copy link

ghost commented Mar 8, 2021

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 8, 2021
@ghost
Copy link

ghost commented Mar 8, 2021

Hi @apoorvajagtap thank you very much for your contribution.

@ghost
Copy link

ghost commented Mar 8, 2021

/retest

@dougsland
Copy link
Contributor

make sense
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2021
@ghost
Copy link

ghost commented Mar 8, 2021

/retest

2 similar comments
@apoorvajagtap
Copy link
Author

/retest

@ghost
Copy link

ghost commented Mar 9, 2021

/retest

@ghost
Copy link

ghost commented Mar 9, 2021

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ghost
Copy link

ghost commented Mar 9, 2021

@apoorvajagtap I have now approved this PR and the bot will "punch it through", no need to run retests manually.

Thank you again for your contribution, this one was on our list but we haven't gotten around to do it. From the feedback we got there are quite a few folks who will appreciate the better naming. :)

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janoszen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@apoorvajagtap
Copy link
Author

Thanks for the help @janoszen. I have been following that BZ for a long time and thought to give it a try. I hope it is helpful. :)

@ghost
Copy link

ghost commented Mar 9, 2021

Awesome work, thanks for tracking it down.

@apoorvajagtap
Copy link
Author

Glad to do that!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2021

@apoorvajagtap: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-workers-rhel7 5beb764 link /test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e3adc54 into openshift:master Mar 9, 2021
@sandrobonazzola
Copy link

Thank you very much @apoorvajagtap for your patch!

@apoorvajagtap
Copy link
Author

Happy to contribute @sandrobonazzola :)

@apoorvajagtap apoorvajagtap deleted the bz/id-1817954 branch March 9, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants