-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1934557: RHCOS boot image bump for LUKS fixes #4778
Bug 1934557: RHCOS boot image bump for LUKS fixes #4778
Conversation
This boot image bump brings in fixes for the following BZs on the RHCOS side: BZ#1934174 - rootfs too small when enabling NBDE BZ#1940704 - prjquota is dropped from rootflags if rootfs is reprovisioned It also brings in support for the new ap-northeast-3 region in AWS. BZ#1939661 - support new AWS region ap-northeast-3
Generated via: ``` $ cd pkg/rhcos $ go run ami_regions_generate.go rhcos ../../data/data/rhcos-amd64.json ami_regions.go ```
@miabbott: This pull request references Bugzilla bug 1934557, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign jlebon |
I've verified that this version of RHCOS fixes the /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
14 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold |
While I'm not opposed technically, I do want to land this bump so that we can verify the 4.8 BZ and unblock the process for getting the 4.7.z bump done to land the fixes for NBDE, prjquota, and new AWS region in Osaka. Can we remove the hold here to unblock the log jam? |
I've rolled in the changes here to #4582 |
For the purpose of cherry-picking to 4.7, it would be easier if this PR merges before #4582. |
Note we can't actually cherry pick because there are separate RHCOS builds per OpenShift version. So no matter what we do, the process will need to be bypassed. But sure, it's fine if this merges first. |
Since it looks like upgrades are going to be on the floor, and bootimage bumps can't affect that (in any way I can think of) let's override? |
/override ci/prow/e2e-aws-upgrade |
@staebler: Overrode contexts on behalf of staebler: ci/prow/e2e-aws-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@miabbott: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/override ci/prow/openstack-manifests |
@staebler: Overrode contexts on behalf of staebler: ci/prow/openstack-manifests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@miabbott: All pull requests linked via external trackers have merged: Bugzilla bug 1934557 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This boot image bump brings in fixes for the following BZs on the
RHCOS side:
BZ#1934174 - rootfs too small when enabling NBDE
BZ#1940704 - prjquota is dropped from rootflags if rootfs is reprovisioned
It also brings in support for the new ap-northeast-3 region in AWS.
BZ#1939661 - support new AWS region ap-northeast-3