Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1934557: RHCOS boot image bump for LUKS fixes #4778

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

miabbott
Copy link
Member

This boot image bump brings in fixes for the following BZs on the
RHCOS side:

BZ#1934174 - rootfs too small when enabling NBDE
BZ#1940704 - prjquota is dropped from rootflags if rootfs is reprovisioned

It also brings in support for the new ap-northeast-3 region in AWS.

BZ#1939661 - support new AWS region ap-northeast-3

This boot image bump brings in fixes for the following BZs on the
RHCOS side:

BZ#1934174 - rootfs too small when enabling NBDE
BZ#1940704 - prjquota is dropped from rootflags if rootfs is reprovisioned

It also brings in support for the new ap-northeast-3 region in AWS.

BZ#1939661 - support new AWS region ap-northeast-3
Generated via:

```
$ cd pkg/rhcos
$ go run ami_regions_generate.go rhcos ../../data/data/rhcos-amd64.json ami_regions.go
```
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 22, 2021
@openshift-ci-robot
Copy link
Contributor

@miabbott: This pull request references Bugzilla bug 1934557, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

Bug 1934557: RHCOS boot image bump for LUKS fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Member Author

/assign jlebon

@jlebon
Copy link
Member

jlebon commented Mar 22, 2021

I've verified that this version of RHCOS fixes the prjquota and LUKS growfs bugs on x86_64 (this time on NVMe, which triggered the lsblk bug).

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2021
@staebler
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@miabbott
Copy link
Member Author

e2e-aws-upgrade, e2e-aws-workers-rhel7, e2e-openstack appear to have been failing well before this PR

e2e-crc was a bit flaky before this PR, though it looks like at least the bootstrap node is getting created

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@cgwalters
Copy link
Member

/hold
Let's rebase this on #4582

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2021
@miabbott
Copy link
Member Author

/hold
Let's rebase this on #4582

While I'm not opposed technically, I do want to land this bump so that we can verify the 4.8 BZ and unblock the process for getting the 4.7.z bump done to land the fixes for NBDE, prjquota, and new AWS region in Osaka.

Can we remove the hold here to unblock the log jam?

@cgwalters
Copy link
Member

I've rolled in the changes here to #4582

@staebler
Copy link
Contributor

/hold
Let's rebase this on #4582

While I'm not opposed technically, I do want to land this bump so that we can verify the 4.8 BZ and unblock the process for getting the 4.7.z bump done to land the fixes for NBDE, prjquota, and new AWS region in Osaka.

Can we remove the hold here to unblock the log jam?

For the purpose of cherry-picking to 4.7, it would be easier if this PR merges before #4582.

@cgwalters
Copy link
Member

Note we can't actually cherry pick because there are separate RHCOS builds per OpenShift version. So no matter what we do, the process will need to be bypassed.

But sure, it's fine if this merges first.

@cgwalters
Copy link
Member

Since it looks like upgrades are going to be on the floor, and bootimage bumps can't affect that (in any way I can think of) let's override?
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2021
@staebler
Copy link
Contributor

/override ci/prow/e2e-aws-upgrade
/skip

@openshift-ci-robot
Copy link
Contributor

@staebler: Overrode contexts on behalf of staebler: ci/prow/e2e-aws-upgrade

In response to this:

/override ci/prow/e2e-aws-upgrade
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2021

@miabbott: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 8be1d9b link /test e2e-openstack
ci/prow/e2e-aws-workers-rhel7 8be1d9b link /test e2e-aws-workers-rhel7
ci/prow/e2e-crc 8be1d9b link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@staebler
Copy link
Contributor

/override ci/prow/openstack-manifests

@openshift-ci-robot
Copy link
Contributor

@staebler: Overrode contexts on behalf of staebler: ci/prow/openstack-manifests

In response to this:

/override ci/prow/openstack-manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit cd630b7 into openshift:master Mar 24, 2021
@openshift-ci-robot
Copy link
Contributor

@miabbott: All pull requests linked via external trackers have merged:

Bugzilla bug 1934557 has been moved to the MODIFIED state.

In response to this:

Bug 1934557: RHCOS boot image bump for LUKS fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants