Bug 1948563: Handle instance_info capabilities and update ironic-terraform #4903
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
iurygregory
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@iurygregory: This pull request references Bugzilla bug 1948563, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @stbenjam |
|
/test e2e-metal-ipi-ovn-ipv6 |
|
I'd not retest IPv6 much, it's pretty broken from https://bugzilla.redhat.com/show_bug.cgi?id=1956281 e2e-metal-ipi is in a little better shape /test e2e-metal-ipi |
|
e2e-metal-ipi seems happy \o/ but all other e2e jobs are red =( |
|
/test e2e-openstack |
|
/test e2e-libvirt |
openshift-ci
bot
added
the
needs-rebase
This commit updates the ironic-terraform-provider to 0.2.6, to handle instance_info/capabilities as strings in the format `key1:value1,key2:value2`. Change the capabilities from `map[string]string` to `string` in `pkg/tfvars/baremetal/baremetal.go`.
iurygregory
force-pushed
the
handle_capabilities_terraform
branch
from
850146c
to
68cced5
Compare
openshift-ci
bot
removed
lgtm
|
/test e2e-metal-ipi |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@iurygregory: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@iurygregory: All pull requests linked via external trackers have merged: Bugzilla bug 1948563 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit updates the ironic-terraform-provider to 0.2.6,
to handle instance_info/capabilities as strings in the format
key1:value1,key2:value2.Change the capabilities from
map[string]stringtostringinpkg/tfvars/baremetal/baremetal.go.