Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Stack: type, validation, & infrastructure manifest #5024

Merged
merged 7 commits into from
Jun 27, 2021
Merged

Azure Stack: type, validation, & infrastructure manifest #5024

merged 7 commits into from
Jun 27, 2021

Commits on Jun 24, 2021

  1. types: add Azure Stack as an azure cloud 

    Add AzureStack as a valid value for the azure cloudName
field. Add the `platform.azure.armEndpoint` field for
specifying the ARM endpoint when installing on Azure Stack.
Add validation specific to Azure Stack.
    @staebler @patrickdillon
    staebler authored and patrickdillon committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    ccd70e2 View commit details
    Browse the repository at this point in the history

  2. Add AzureStack Session Support 

    Modifies session retrieval to accept an ARM endpoint which will be
needed for Azure Stack.
    @patrickdillon
    patrickdillon committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    4fcb3bb View commit details
    Browse the repository at this point in the history

  3. pkg/manifests: Add ARMEndpoint to Azure Stack Infrastructure object 

    On the Azure Stack platform the ARM Endpoint should be part of the
infrastructure status. Writing the endpoint to the object allows
cluster operators to connect to the ARM Endpoint and discover other
endpoints.
    @patrickdillon
    patrickdillon committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    ddd69f1 View commit details
    Browse the repository at this point in the history

  4. Vendor: openshift/api for azure stack infra 

    Pull in updated OpenShift API to write infrastructure object for Azure
Stack Hub. Commit generated with:

go mod edit -require=github.com/openshift/api@master
go mod vendor
go mod tidy
    @patrickdillon
    patrickdillon committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    5a8363a View commit details
    Browse the repository at this point in the history

  5. Azure Session: use Token Audience for auth 

    The authorizer for Azure should use the env.TokenAudience rather than
the env.ResourceManagerEndpoint. Using the Resource Manager Endpoint in
Azure Stack Hub results in errors such as:

The resource principal named https://management.ppe3.stackpoc.com was not
found in the tenant named 6047c7e9-b2ad-488d-a54e-dc3f6be6a7ee. This can
happen if the application has not been installed by the administrator of
the tenant or consented to by any user in the tenant. You might have sent
your authentication request to the wrong tenant.
    @staebler @patrickdillon
    staebler authored and patrickdillon committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    c1bd250 View commit details
    Browse the repository at this point in the history

  6. Add Default Instance Types for Azure Stack 

    Also simplifies Azure Stack IPv6 validation.
    @staebler @patrickdillon
    staebler authored and patrickdillon committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    fc93d0e View commit details
    Browse the repository at this point in the history

  7. .yamllint: ignore cluster-networkconfig-crd.yaml 

    data/data/manifests/openshift/cluster-networkconfig-crd.yaml is a
symlink to a vendored file. yamllint should ignored vendored files. I
don't see a generic way to ignore symlinks based on their targets, so
I'm adding this explicit path.
    @patrickdillon
    patrickdillon committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    b8c095f View commit details
    Browse the repository at this point in the history