Azure Stack: type, validation, & infrastructure manifest #5024
Conversation
patrickdillon
force-pushed
the
azurestack-type
branch
from
d53216b
to
b258595
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
patrickdillon
force-pushed
the
azurestack-type
branch
2 times, most recently
from
ed29bb9
to
a8567c3
Compare
|
Including #5030 to test whether this solves yamllint issue (yaml-lint is failing on symlink to files vendored in this PR) |
Add AzureStack as a valid value for the azure cloudName field. Add the `platform.azure.armEndpoint` field for specifying the ARM endpoint when installing on Azure Stack. Add validation specific to Azure Stack.
Modifies session retrieval to accept an ARM endpoint which will be needed for Azure Stack.
On the Azure Stack platform the ARM Endpoint should be part of the infrastructure status. Writing the endpoint to the object allows cluster operators to connect to the ARM Endpoint and discover other endpoints.
Pull in updated OpenShift API to write infrastructure object for Azure Stack Hub. Commit generated with: go mod edit -require=github.com/openshift/api@master go mod vendor go mod tidy
The authorizer for Azure should use the env.TokenAudience rather than the env.ResourceManagerEndpoint. Using the Resource Manager Endpoint in Azure Stack Hub results in errors such as: The resource principal named https://management.ppe3.stackpoc.com was not found in the tenant named 6047c7e9-b2ad-488d-a54e-dc3f6be6a7ee. This can happen if the application has not been installed by the administrator of the tenant or consented to by any user in the tenant. You might have sent your authentication request to the wrong tenant.
Also simplifies Azure Stack IPv6 validation.
data/data/manifests/openshift/cluster-networkconfig-crd.yaml is a symlink to a vendored file. yamllint should ignored vendored files. I don't see a generic way to ignore symlinks based on their targets, so I'm adding this explicit path.
patrickdillon
force-pushed
the
azurestack-type
branch
from
a8567c3
to
b8c095f
Compare
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
22 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@patrickdillon: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR takes the bits of #4823 and #4799 that I believe are ready to merge and can provide a foundation to build from.
Individual commits should have explanations in the commit messages.
This will be followed up with a PR to add support for the cloud provider config and update the APIs to the hybrid profiles for ASH support.