Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.yamllint: ignore cluster-networkconfig-crd.yaml #5030

Conversation

patrickdillon
Copy link
Contributor

data/data/manifests/openshift/cluster-networkconfig-crd.yaml is a
symlink to a vendored file. yamllint should ignored vendored files. I
don't see a generic way to ignore symlinks based on their targets, so
I'm adding this explicit path.

data/data/manifests/openshift/cluster-networkconfig-crd.yaml is a
symlink to a vendored file. yamllint should ignored vendored files. I
don't see a generic way to ignore symlinks based on their targets, so
I'm adding this explicit path.
@patrickdillon
Copy link
Contributor Author

@patrickdillon
Copy link
Contributor Author

ignoring all symlinks would work, but i can't figure out how to do that either

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

@patrickdillon: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt f955d09 link /test e2e-libvirt
ci/prow/e2e-aws-fips f955d09 link /test e2e-aws-fips
ci/prow/e2e-aws-workers-rhel7 f955d09 link /test e2e-aws-workers-rhel7
ci/prow/e2e-crc f955d09 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2021
@staebler
Copy link
Contributor

This is just changes to the behavior of the linter.
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade
/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@staebler: Overrode contexts on behalf of staebler: ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade

In response to this:

This is just changes to the behavior of the linter.
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 75032f9 into openshift:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants