New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.yamllint: ignore cluster-networkconfig-crd.yaml #5030
.yamllint: ignore cluster-networkconfig-crd.yaml #5030
Conversation
data/data/manifests/openshift/cluster-networkconfig-crd.yaml is a symlink to a vendored file. yamllint should ignored vendored files. I don't see a generic way to ignore symlinks based on their targets, so I'm adding this explicit path.
Just tested on #5024 and this PR causes previous failures to pass: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/5024/pull-ci-openshift-installer-master-yaml-lint/1408119842770259968 |
ignoring all symlinks would work, but i can't figure out how to do that either |
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is just changes to the behavior of the linter. |
@staebler: Overrode contexts on behalf of staebler: ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
data/data/manifests/openshift/cluster-networkconfig-crd.yaml is a
symlink to a vendored file. yamllint should ignored vendored files. I
don't see a generic way to ignore symlinks based on their targets, so
I'm adding this explicit path.