-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verify-vendor: add go mod tidy #5076
verify-vendor: add go mod tidy #5076
Conversation
/hold for discussion. I think we want this but not certain |
/hold cancel |
I agree. Any idea why verify-vendor is failing? |
Agreed. |
Master is broken due to the changes in e1646dd. That PR passed the verify-vendor test, which prompted this PR. So verify-vendor in this PR is correctly identifying the broken state of master. I have a couple of PRs open to resolve the issue with master but these PRs are upstream. Hopefully we can merge them quickly. |
/test verify-vendor |
1 similar comment
/test verify-vendor |
/assign |
e1646dd introduced a dependency on github.com/IBM/apigateway-go-sdk. The upstream repo was ambiguously structured and has been fixed. This vendoring pulls in the updated repos.
1276fee
to
fa76c3e
Compare
A recent commit passed the CI test for go mod tidy but introduced a bug in master when we run go mod tidy. By including go mod tidy, we can catch these earlier.
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Running go mod tidy before vendoring ensures all necessary dependencies are included in go.mod.
e1646dd introduced dependencies that failed to vendor locally but passed our verify-vendor test.
Including
go mod tidy
exposes these errors.