Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify-vendor: add go mod tidy #5076

Merged
merged 2 commits into from Jul 15, 2021
Merged

verify-vendor: add go mod tidy #5076

merged 2 commits into from Jul 15, 2021

Conversation

patrickdillon
Copy link
Contributor

Running go mod tidy before vendoring ensures all necessary dependencies are included in go.mod.

e1646dd introduced dependencies that failed to vendor locally but passed our verify-vendor test.

Including go mod tidy exposes these errors.

@patrickdillon
Copy link
Contributor Author

/hold for discussion. I think we want this but not certain

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2021
@patrickdillon
Copy link
Contributor Author

/hold cancel
Enforcing go mod tidy makes sense to me

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2021
@jhixson74
Copy link
Member

/hold cancel
Enforcing go mod tidy makes sense to me

I agree. Any idea why verify-vendor is failing?

@mtnbikenc
Copy link
Member

Agreed.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2021
@patrickdillon
Copy link
Contributor Author

I agree. Any idea why verify-vendor is failing?

Master is broken due to the changes in e1646dd. That PR passed the verify-vendor test, which prompted this PR.

So verify-vendor in this PR is correctly identifying the broken state of master.

I have a couple of PRs open to resolve the issue with master but these PRs are upstream. Hopefully we can merge them quickly.

@jstuever
Copy link
Contributor

/test verify-vendor

1 similar comment
@jstuever
Copy link
Contributor

/test verify-vendor

@jstuever
Copy link
Contributor

/assign

@patrickdillon
vendor: Revendor terraform-provider-ibm and dependencies
fa76c3e 
e1646dd introduced a dependency on
github.com/IBM/apigateway-go-sdk. The upstream repo was ambiguously
structured and has been fixed. This vendoring pulls in the updated
repos.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2021
@patrickdillon
verify-vendor: add go mod tidy
1022e0d 
A recent commit passed the CI test for go mod tidy but introduced a bug
in master when we run go mod tidy. By including go mod tidy, we can
catch these earlier.
@patrickdillon
Copy link
Contributor Author

/retest

@jstuever
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack-kuryr 1022e0d link /test e2e-openstack-kuryr
ci/prow/e2e-ovirt 1022e0d link /test e2e-ovirt
ci/prow/e2e-libvirt 1022e0d link /test e2e-libvirt
ci/prow/e2e-openstack 1022e0d link /test e2e-openstack
ci/prow/e2e-aws-workers-rhel7 1022e0d link /test e2e-aws-workers-rhel7
ci/prow/e2e-crc 1022e0d link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 252facf into openshift:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-tienne e-tienne Awaiting requested review from e-tienne

@jhixson74 jhixson74 Awaiting requested review from jhixson74

Assignees

@mtnbikenc mtnbikenc

@jstuever jstuever

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@patrickdillon @jhixson74 @mtnbikenc @jstuever @openshift-bot @openshift-merge-robot