Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurestack: Add subnet nsg group association in terraform #5150

Merged
merged 1 commit into from
Oct 7, 2021
Merged

azurestack: Add subnet nsg group association in terraform #5150

merged 1 commit into from
Oct 7, 2021

Conversation

rna-afk
Copy link
Contributor

@rna-afk rna-afk commented Aug 16, 2021 •
edited
Loading

Adding azurestack_subnet_network_security_group_association resource
to azure stack hub to associate the network security group and the
subnet created for both the control-plane and the worker nodes.

@jstuever
Copy link
Contributor

/assign @patrickdillon

@rna-afk
Copy link
Contributor Author

rna-afk commented Sep 20, 2021

/test e2e-azure-upi
Looks like e2e-azure-upi is not working so I want to test it here since this has no effect on the upi.

@rna-afk
Copy link
Contributor Author

rna-afk commented Sep 27, 2021

/test e2e-azurestack

@staebler
Copy link
Contributor

In order to do IPI testing, login to the Azure Stack Hub is necessary
as it is private and not accessible ordinarily. Installing az cli
in the IPI image to allow for login to the Azure Stack Hub.

How does this PR description relate to the contents of this PR?

@rna-afk
Copy link
Contributor Author

rna-afk commented Sep 27, 2021

I am totally stumped how that creeped in. Changing it thanks!

jstuever
jstuever reviewed Oct 6, 2021
View reviewed changes
Copy link
Contributor

@jstuever jstuever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2021
@staebler
Copy link
Contributor

staebler commented Oct 6, 2021

@rna-afk Could you improve on the description of this PR and the commit message? "Add additional resources in terraform" is too general.

@rna-afk rna-afk force-pushed the azurestack_additional_resources branch from fb47b95 to 809b850 Compare October 7, 2021 12:49
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2021
@rna-afk rna-afk force-pushed the azurestack_additional_resources branch from 809b850 to 9bac94b Compare October 7, 2021 12:53
@rna-afk
azurestack: Add additional resources in terraform
ec9ae86 
Adding azurestack_subnet_network_security_group_association resource
to azure stack hub to associate the network security group and the
subnet created for both the control-plane and the workers.
@rna-afk rna-afk force-pushed the azurestack_additional_resources branch from 9bac94b to ec9ae86 Compare October 7, 2021 12:56
@rna-afk rna-afk changed the title azurestack: Add additional resources in terraform azurestack: Add subnet nsg group association in terraform Oct 7, 2021
@staebler
Copy link
Contributor

staebler commented Oct 7, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2021 •
edited
Loading

@rna-afk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-byon fb47b95 link /test e2e-openstack-byon
ci/prow/e2e-metal-ipi-ovn-ipv6-required fb47b95 link /test e2e-metal-ipi-ovn-ipv6-required
ci/prow/e2e-azure-upi fb47b95 link false /test e2e-azure-upi
ci/prow/e2e-azurestack fb47b95 link false /test e2e-azurestack
ci/prow/e2e-aws-workers-rhel7 ec9ae86 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-workers-rhel8 ec9ae86 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-crc ec9ae86 link false /test e2e-crc
ci/prow/e2e-aws-fips ec9ae86 link false /test e2e-aws-fips
ci/prow/e2e-metal-ipi-ovn-ipv6 ec9ae86 link false /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8322e41 into openshift:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever jstuever left review comments

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@patrickdillon patrickdillon

@jstuever jstuever

@staebler staebler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rna-afk @jstuever @staebler @openshift-bot @patrickdillon @openshift-merge-robot