Bug 1993364: openstack/destroy: fix Kuryr/BYON #5191
Conversation
|
@MaysaMacedo: This pull request references Bugzilla bug 1993364, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-medium
|
@MaysaMacedo: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/bugzilla refresh The requirements for Bugzilla bugs have changed, recalculating validity. |
|
@openshift-merge-robot: This pull request references Bugzilla bug 1993364, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@EmilienM: This pull request references Bugzilla bug 1993364, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
When using byon with Kuryr the Router would be identified based on the Primary Network used by the Servers, which would be filtered by the device-owner compute:nova. However, when using azs the device-owner name can change. This commit fixes the issue by identifying the router by looking for any tagged networks that has a subnet connected to the router. The gorouting for this approach can't be run before other clean ups because the CNO would always attempt to re-connect the service subnet to the router. Co-Authored-By: Maysa Macedo <maysa.macedo95@gmail.com> Co-Authored-By: Emilien Macchi <emilien@redhat.com>
MaysaMacedo
force-pushed
the
fix-byon-destroy
branch
from
f4023b2
to
1d87b08
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@MaysaMacedo: All pull requests linked via external trackers have merged: Bugzilla bug 1993364 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.9 |
|
@MaysaMacedo: new pull request created: #5215 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When using byon with Kuryr the Router would be identified based
on the Primary Network used by the Servers, which would be filtered
by the device-owner compute:nova. However, when using azs the
device-owner name can change. This commit fixes the issue by
identifying the router by looking for any tagged networks that
has a subnet connected to the router. The gorouting for this
approach can't be run before other clean ups because the CNO
would always attempt to re-connect the service subnet to the
router.
Co-Authored-By: Maysa Macedo maysa.macedo95@gmail.com
Co-Authored-By: Emilien Macchi emilien@redhat.com