Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libvirt cluster-api provider config version #523

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Update libvirt cluster-api provider config version #523

merged 1 commit into from
Oct 24, 2018

Conversation

bison
Copy link
Contributor

@bison bison commented Oct 23, 2018

With the move to the kubebuilder CRD based cluster-api components, the
API version for the libvirt provider config subresources has changed
to: libvirtproviderconfig.k8s.io/v1alpha1

With the move to the kubebuilder CRD based cluster-api components, the
API version for the libvirt provider config subresources has changed
to: libvirtproviderconfig.k8s.io/v1alpha1
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2018
@abhinavdahiya
Copy link
Contributor

What PR made that change in cluster-api-provider-libvirt?

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2018
@bison
Copy link
Contributor Author

bison commented Oct 23, 2018

I think it was openshift/cluster-api-provider-libvirt#72. That was merged into the crd branch, which is what is being deployed now I guess.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 23, 2018

@bison where did you get libvirtproviderconfig.k8s.io/v1alpha1 ?
https://github.com/openshift/cluster-api-provider-libvirt/blob/master/pkg/cloud/libvirt/providerconfig/v1alpha1/register.go#L35-L39 this has the old api group name.

@bison
Copy link
Contributor Author

bison commented Oct 23, 2018

@abhinavdahiya check the crd branch not master. We're in the middle of the migration from aggregated API to CRDs, so we're on this CRD branch for now.

@enxebre and @ingvagabund probably know more about the plan / timing there if you have questions on that.

@bison
Copy link
Contributor Author

bison commented Oct 23, 2018

I'm pretty sure the e2e failure is unrelated to this... I'll try again though

/test e2e-aws

@ingvagabund
Copy link
Member

The new provider config (for both aws and libvirt) were generated by the kubebuilder command. Even @enxebre 's migrated aws actuator has the k8s.io suffix: https://github.com/openshift/cluster-api-provider-aws/blob/crd/pkg/apis/awsproviderconfig/v1alpha1/register.go#L39

@rphillips
Copy link
Contributor

/test e2e-aws

2 similar comments
@enxebre
Copy link
Member

enxebre commented Oct 24, 2018

/test e2e-aws

@bison
Copy link
Contributor Author

bison commented Oct 24, 2018

/test e2e-aws

@abhinavdahiya
Copy link
Contributor

Can you post the error from e2e before you retest.

@bison
Copy link
Contributor Author

bison commented Oct 24, 2018

Sure, the last one was aborted, so I didn't see much worthwhile. I'll post the results of the current run.

@sjenning
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, bison, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3fa7a19 into openshift:master Oct 24, 2018
@bison bison deleted the libvirtprovider-version branch October 24, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants