-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libvirt cluster-api provider config version #523
Update libvirt cluster-api provider config version #523
Conversation
With the move to the kubebuilder CRD based cluster-api components, the API version for the libvirt provider config subresources has changed to: libvirtproviderconfig.k8s.io/v1alpha1
What PR made that change in cluster-api-provider-libvirt? |
/approve |
I think it was openshift/cluster-api-provider-libvirt#72. That was merged into the |
@bison where did you get |
@abhinavdahiya check the crd branch not master. We're in the middle of the migration from aggregated API to CRDs, so we're on this CRD branch for now. @enxebre and @ingvagabund probably know more about the plan / timing there if you have questions on that. |
I'm pretty sure the e2e failure is unrelated to this... I'll try again though /test e2e-aws |
The new provider config (for both aws and libvirt) were generated by the |
/test e2e-aws |
2 similar comments
/test e2e-aws |
/test e2e-aws |
Can you post the error from e2e before you retest. |
Sure, the last one was aborted, so I didn't see much worthwhile. I'll post the results of the current run. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, bison, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With the move to the kubebuilder CRD based cluster-api components, the
API version for the libvirt provider config subresources has changed
to:
libvirtproviderconfig.k8s.io/v1alpha1