Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bootstrap image asset depend on rhcos image. #5267

Merged

Conversation

patrickdillon
Copy link
Contributor

The bootstrap image asset calls the rhcos package to determine the rhcos image for the boostrap node. Instead it should
look for the rhcos image in the asset store.

The bootstrap image asset calls the rhcos package to
determine the rhcos image for the boostrap node. Instead it should
look for the rhcos image in the asset store.
openshift-install graph | dot -Tsvg >docs/design/resource_dep.svg
@kwoodson
Copy link
Contributor

kwoodson commented Oct 5, 2021

@patrickdillon Thanks, I'll try this out.

@kwoodson
Copy link
Contributor

kwoodson commented Oct 5, 2021

@patrickdillon This worked for me.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2021

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-kuryr 806937b link false /test e2e-openstack-kuryr
ci/prow/e2e-aws-workers-rhel8 806937b link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-workers-rhel7 806937b link false /test e2e-aws-workers-rhel7
ci/prow/e2e-ovirt 806937b link false /test e2e-ovirt
ci/prow/e2e-metal-single-node-live-iso 806937b link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-metal-ipi-ovn-ipv6 806937b link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-crc 806937b link false /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@staebler
Copy link
Contributor

staebler commented Oct 5, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit 3c455c2 into openshift:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants