Bug 2012235: IBM Cloud: Add RG to CP config #5294

cjschaef · 2021-10-13T15:58:27Z

Add the ResourceGroupName into the IBM Cloud provider config as
a required value for the CCM.

openshift-ci · 2021-10-13T15:58:31Z

@cjschaef: This pull request references Bugzilla bug 2012235, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2012235: IBM Cloud: Add RG to CP config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jstuever · 2021-10-13T18:58:47Z

/bugzilla refresh

openshift-ci · 2021-10-13T18:58:54Z

@jstuever: This pull request references Bugzilla bug 2012235, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @pamoedom

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jstuever

One minor ask, otherwise looks good.

jstuever · 2021-10-13T19:03:46Z

pkg/asset/manifests/cloudproviderconfig.go

@@ -191,7 +191,7 @@ func (cpc *CloudProviderConfig) Generate(dependencies asset.Parents) error {
 			}
 		}

-		ibmcloudConfig, err := ibmcloudmanifests.CloudProviderConfig(clusterID.InfraID, accountID, installConfig.Config.IBMCloud.Region, controlPlane.Zones, compute.Zones)
+		ibmcloudConfig, err := ibmcloudmanifests.CloudProviderConfig(clusterID.InfraID, accountID, installConfig.Config.IBMCloud.Region, installConfig.Config.Platform.IBMCloud.ClusterResourceGroupName(clusterID.InfraID), controlPlane.Zones, compute.Zones)


This line is getting complex. Please set the the resourceGroupName to a variable and use it here. ie:

resouceGroupName := installConfig.Config.Platform.IBMCloud.ClusterResourceGroupName(clusterID.InfraID) ibmcloudConfig, err := ibmcloudmanifests.CloudProviderConfig(clusterID.InfraID, accountID, installConfig.Config.IBMCloud.Region, resourceGroupName, controlPlane.Zones, compute.Zones)

Add the ResourceGroupName into the IBM Cloud provider config as a required value for the CCM.

pamoedom

/lgtm

pamoedom · 2021-10-14T09:28:00Z

/label qe-approved

$ ./openshift-install-local create manifests --dir test39/ --log-level debug
DEBUG OpenShift Installer unreleased-master-5105-gb018924f1f97737518147bf6088e3463f9c7ceb9 
DEBUG Built from commit b018924f1f97737518147bf6088e3463f9c7ceb9
...
DEBUG Generating Openshift Manifests...            
INFO Manifests created in: test39/manifests and test39/openshift

$ grep "ResourceGroup" test39/manifests/cloud-provider-config.yaml 
    g2ResourceGroupName = pamoedom-rg

Regards.

jstuever

/approve

openshift-ci · 2021-10-14T15:51:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jeffnowicki · 2021-10-14T17:41:16Z

/retest-required

openshift-bot · 2021-10-14T18:19:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-14T18:55:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-14T20:11:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-10-14T21:02:05Z

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-kuryr	`b018924`	link	false	`/test e2e-openstack-kuryr`
ci/prow/e2e-ovirt	`b018924`	link	false	`/test e2e-ovirt`
ci/prow/e2e-aws-workers-rhel8	`b018924`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-aws-workers-rhel7	`b018924`	link	false	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-metal-ipi-ovn-ipv6	`b018924`	link	false	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-crc	`b018924`	link	false	`/test e2e-crc`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-10-14T21:14:51Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-14T21:27:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-14T21:40:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-14T23:11:51Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-14T23:24:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-10-14T23:28:01Z

@cjschaef: All pull requests linked via external trackers have merged:

openshift/installer#5294

Bugzilla bug 2012235 has been moved to the MODIFIED state.

In response to this:

Bug 2012235: IBM Cloud: Add RG to CP config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 13, 2021

openshift-ci bot requested review from e-tienne and rna-afk October 13, 2021 16:02

cjschaef force-pushed the bz_2012235 branch from 3d1f6ff to d60efb4 Compare October 13, 2021 17:01

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 13, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 13, 2021

openshift-ci bot requested a review from pamoedom October 13, 2021 18:58

jstuever requested changes Oct 13, 2021

View reviewed changes

Bug 2012235: IBM Cloud: Add RG to CP config

b018924

Add the ResourceGroupName into the IBM Cloud provider config as a required value for the CCM.

cjschaef force-pushed the bz_2012235 branch from d60efb4 to b018924 Compare October 13, 2021 20:06

pamoedom reviewed Oct 14, 2021

View reviewed changes

openshift-ci bot assigned pamoedom Oct 14, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 14, 2021

xiuwang mentioned this pull request Oct 14, 2021

feat(ibmcos): Define IAM policies for CredentialsRequest openshift/cluster-image-registry-operator#716

Merged

jstuever self-requested a review October 14, 2021 15:50

jstuever approved these changes Oct 14, 2021

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021

openshift-merge-robot merged commit 95361b7 into openshift:master Oct 14, 2021

cjschaef deleted the bz_2012235 branch October 15, 2021 13:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2012235: IBM Cloud: Add RG to CP config #5294

Bug 2012235: IBM Cloud: Add RG to CP config #5294

cjschaef commented Oct 13, 2021

openshift-ci bot commented Oct 13, 2021

jstuever commented Oct 13, 2021

openshift-ci bot commented Oct 13, 2021

jstuever left a comment

jstuever Oct 13, 2021

cjschaef Oct 13, 2021

pamoedom left a comment

pamoedom commented Oct 14, 2021

jstuever left a comment

openshift-ci bot commented Oct 14, 2021

jeffnowicki commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-ci bot commented Oct 14, 2021 •

edited

Loading

openshift-bot commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-ci bot commented Oct 14, 2021

Bug 2012235: IBM Cloud: Add RG to CP config #5294

Bug 2012235: IBM Cloud: Add RG to CP config #5294

Conversation

cjschaef commented Oct 13, 2021

openshift-ci bot commented Oct 13, 2021

jstuever commented Oct 13, 2021

openshift-ci bot commented Oct 13, 2021

jstuever left a comment

Choose a reason for hiding this comment

jstuever Oct 13, 2021

Choose a reason for hiding this comment

cjschaef Oct 13, 2021

Choose a reason for hiding this comment

pamoedom left a comment

Choose a reason for hiding this comment

pamoedom commented Oct 14, 2021

jstuever left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Oct 14, 2021

jeffnowicki commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-ci bot commented Oct 14, 2021 • edited Loading

openshift-bot commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-ci bot commented Oct 14, 2021

openshift-ci bot commented Oct 14, 2021 •

edited

Loading