-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alibaba: fix: remove the default value #5410
Alibaba: fix: remove the default value #5410
Conversation
Hi @bd233. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -43,7 +43,6 @@ variable "system_disk_size" { | |||
variable "system_disk_category" { | |||
type = string | |||
description = "The system disk category of the master ECS.Valid values are cloud_efficiency, cloud_ssd, cloud_essd. Default value is cloud_essd." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The system disk category of the master ECS.Valid values are cloud_efficiency, cloud_ssd, cloud_essd. Default value is cloud_essd." | |
description = "The system disk category of the master ECS. Valid values are cloud_efficiency, cloud_ssd, cloud_essd." |
@@ -48,7 +48,6 @@ variable "ali_system_disk_size" { | |||
variable "ali_system_disk_category" { | |||
type = string | |||
description = "The system disk category of the master ECS.Valid values are cloud_efficiency, cloud_ssd, cloud_essd. Default value is cloud_essd." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The system disk category of the master ECS.Valid values are cloud_efficiency, cloud_ssd, cloud_essd. Default value is cloud_essd." | |
description = "The system disk category of the master ECS. Valid values are cloud_efficiency, cloud_ssd, cloud_essd." |
@@ -59,7 +58,6 @@ variable "ali_extra_tags" { | |||
|
|||
Example: `{ "key" = "value", "foo" = "bar" }` | |||
EOF | |||
default = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this default also requires removing the omitempty
from the field in the tfvars struct.
ExtraTags map[string]string `json:"ali_extra_tags,omitempty"` |
Remove the default value in terraform variables, because the root module and tfvars file should always be explicitly supplying a value. Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>
e3d0003
to
3625389
Compare
@staebler Have updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is pretty straightforward. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@bd233: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Remove the default value in terraform variables, because the root module
and tfvars file should always be explicitly supplying a value.