add configmap etcd-serving-ca.kube-system #551

sanchezl · 2018-10-26T19:52:38Z

manifests: add secret etcd-client.kube-system (used to be in cluster-kube-apiserver-operator renderer)
docs: updated the dependency graph at docs/design/resource_dep.svg

deads2k · 2018-10-26T20:00:27Z

pkg/asset/manifests/content/bootkube/kube-system-configmap-etcd-serving-ca.go

+    openshift.io/component: "api"
+data:
+  ca-bundle.crt: |
+    {{ .Assets | load .EtcdServingCA | indent 4 }}


Please link me to where this gets substituted. I would expect this to fail.

deads2k · 2018-10-26T20:01:25Z

pkg/asset/manifests/operators.go

@@ -191,6 +191,7 @@ func (m *Manifests) generateBootKubeManifests(dependencies asset.Parents) []*ass
 		"app-version-kind.yaml":                      []byte(bootkube.AppVersionKind),
 		"app-version-tectonic-network.yaml":          []byte(bootkube.AppVersionTectonicNetwork),
 		"etcd-service.yaml":                          []byte(bootkube.EtcdServiceKubeSystem),
+		"kube-system-configmap-etcd-serving-ca.yaml": []byte(bootkube.KubeSystemConfigmapEtcdServingCA),


Have you tested this? template substitution appears to happen in the stanza above, though even so I think the parameters used don't match this pull.

deads2k · 2018-10-26T20:02:39Z

@sanchezl contribution requirements to this repo are different. please adjust your commit message per https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#commit-message-format and our agreement with @crawford and @abhinavdahiya

pkg/asset/manifests/content/bootkube/kube-system-configmap-etcd-serving-ca.go

deads2k · 2018-10-30T13:18:10Z

@sanchezl is this one ready now?

wking · 2018-10-30T17:36:14Z

The 62da5b2 commit message says:

The renderer in cluster-kube-apiserver-operator will need to be also changed to stop creating the same manifest file.

But on a quick skim, I didn't see any PRs there making that change. Can you link us to the operator change?

sanchezl · 2018-10-30T17:51:13Z

The 62da5b2 commit message says:

The renderer in cluster-kube-apiserver-operator will need to be also changed to stop creating the same manifest file.

But on a quick skim, I didn't see any PRs there making that change. Can you link us to the operator change?

Opened openshift/cluster-kube-apiserver-operator#97

abhinavdahiya · 2018-10-31T15:03:40Z

/lgtm

openshift-merge-robot · 2018-10-31T16:01:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot · 2018-10-31T20:03:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

abhinavdahiya · 2018-10-31T21:32:58Z

/retest

openshift-merge-robot · 2018-11-01T00:06:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2018-11-01T04:41:02Z

pkg/asset/manifests/content/bootkube/kube-system-configmap-etcd-serving-ca.go

+    tier: "control-plane"
+    k8s-app: "kube-apiserver"
+    openshift.io/control-plane: "true"
+    openshift.io/component: "api"


As here, it would be nice to know what these labels are for. That makes us less likely to break things accidentally if someone proposes we change/remove one of them later ;).

As here, it would be nice to know what these labels are for. That makes us less likely to break things accidentally if someone proposes we change/remove one of them later ;).

@sanchezl they aren't for us. Remove all labels and the etcd operator can sort out what they want to do.

Removed them all.

deads2k · 2018-11-02T13:30:51Z

@abhinavdahiya it was rebased and labels removed. As a general statement, do you mind me re-labeling simple changes like that?

abhinavdahiya · 2018-11-02T13:36:07Z

@abhinavdahiya it was rebased and labels removed. As a general statement, do you mind me re-labeling simple changes like that?

Sure, except approved and lgtm ;p :D
Usually the CI handles the rebase labels, but somehow here it forgot

/lgtm

openshift-merge-robot · 2018-11-02T16:23:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

deads2k · 2018-11-02T18:51:46Z

@sanchezl indicate what changed and why

sanchezl · 2018-11-02T19:31:13Z

@sanchezl indicate what changed and why

rebased and generated new dependency graph

Manifest to create this resources belongs in installer. The renderer in cluster-kube-apiserver-operator will need to be also changed to stop creating the same manifest file. Also, updated the dependency graph at docs/design/resource_dep.svg

abhinavdahiya · 2018-11-05T16:17:04Z

/lgtm

openshift-ci-robot · 2018-11-05T16:17:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [abhinavdahiya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deads2k · 2018-11-05T18:45:04Z

/retest

just to see

openshift-ci-robot requested review from abhinavdahiya and wking October 26, 2018 19:52

openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 26, 2018

deads2k reviewed Oct 26, 2018

View reviewed changes

sanchezl force-pushed the move_manifest_etcd_serving_ca_configmap branch from 9b36697 to 04809f8 Compare October 26, 2018 20:12

sanchezl changed the title ~~move kube-system-configmap-etcd-serving-ca.yaml to installer~~ [WIP] move kube-system-configmap-etcd-serving-ca.yaml to installer Oct 26, 2018

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2018

sanchezl force-pushed the move_manifest_etcd_serving_ca_configmap branch from 04809f8 to b78f984 Compare October 26, 2018 21:05

abhinavdahiya reviewed Oct 26, 2018

View reviewed changes

pkg/asset/manifests/content/bootkube/kube-system-configmap-etcd-serving-ca.go Show resolved Hide resolved

abhinavdahiya changed the title ~~[WIP] move kube-system-configmap-etcd-serving-ca.yaml to installer~~ [WIP] add kube-system-configmap-etcd-serving-ca.yaml Oct 26, 2018

sanchezl force-pushed the move_manifest_etcd_serving_ca_configmap branch from b78f984 to 62da5b2 Compare October 30, 2018 01:47

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2018

sanchezl changed the title ~~[WIP] add kube-system-configmap-etcd-serving-ca.yaml~~ add kube-system-configmap-etcd-serving-ca.yaml Oct 30, 2018

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2018

sanchezl mentioned this pull request Oct 30, 2018

remove manifests added to the installer openshift/cluster-kube-apiserver-operator#97

Closed

sanchezl changed the title ~~add kube-system-configmap-etcd-serving-ca.yaml~~ add configmap etcd-serving-ca.kube-system Oct 31, 2018

openshift-ci-robot assigned abhinavdahiya Oct 31, 2018

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2018

abhinavdahiya added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2018

wking reviewed Nov 1, 2018

View reviewed changes

sanchezl force-pushed the move_manifest_etcd_serving_ca_configmap branch from 62da5b2 to 81f5066 Compare November 1, 2018 04:57

openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2018

sanchezl force-pushed the move_manifest_etcd_serving_ca_configmap branch from 81f5066 to 414aab1 Compare November 1, 2018 14:01

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 1, 2018

sanchezl force-pushed the move_manifest_etcd_serving_ca_configmap branch from 414aab1 to 67124a9 Compare November 1, 2018 14:38

deads2k removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2018

abhinavdahiya added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2018

sanchezl force-pushed the move_manifest_etcd_serving_ca_configmap branch from 67124a9 to f68c64f Compare November 2, 2018 18:15

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 2, 2018

manifests: new secret etcd-client.kube-system

7294a3d

Manifest to create this resources belongs in installer. The renderer in cluster-kube-apiserver-operator will need to be also changed to stop creating the same manifest file. Also, updated the dependency graph at docs/design/resource_dep.svg

sanchezl force-pushed the move_manifest_etcd_serving_ca_configmap branch from f68c64f to 7294a3d Compare November 4, 2018 18:04

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2018

openshift-merge-robot merged commit 336c87e into openshift:master Nov 5, 2018

wking mentioned this pull request Nov 7, 2018

The pod of the CVO cannot restart via the daemonset #620

Closed

sanchezl deleted the move_manifest_etcd_serving_ca_configmap branch March 19, 2019 18:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add configmap etcd-serving-ca.kube-system #551

add configmap etcd-serving-ca.kube-system #551

sanchezl commented Oct 26, 2018 •

edited

Loading

deads2k Oct 26, 2018

sanchezl Oct 31, 2018

deads2k Oct 26, 2018

sanchezl Oct 31, 2018

deads2k commented Oct 26, 2018

deads2k commented Oct 30, 2018

wking commented Oct 30, 2018

sanchezl commented Oct 30, 2018

abhinavdahiya commented Oct 31, 2018

openshift-merge-robot commented Oct 31, 2018

openshift-merge-robot commented Oct 31, 2018

abhinavdahiya commented Oct 31, 2018

openshift-merge-robot commented Nov 1, 2018

wking Nov 1, 2018

deads2k Nov 1, 2018

sanchezl Nov 1, 2018

deads2k commented Nov 2, 2018

abhinavdahiya commented Nov 2, 2018 •

edited

Loading

openshift-merge-robot commented Nov 2, 2018

deads2k commented Nov 2, 2018

sanchezl commented Nov 2, 2018

abhinavdahiya commented Nov 5, 2018

openshift-ci-robot commented Nov 5, 2018

deads2k commented Nov 5, 2018

add configmap etcd-serving-ca.kube-system #551

add configmap etcd-serving-ca.kube-system #551

Conversation

sanchezl commented Oct 26, 2018 • edited Loading

deads2k Oct 26, 2018

Choose a reason for hiding this comment

sanchezl Oct 31, 2018

Choose a reason for hiding this comment

deads2k Oct 26, 2018

Choose a reason for hiding this comment

sanchezl Oct 31, 2018

Choose a reason for hiding this comment

deads2k commented Oct 26, 2018

deads2k commented Oct 30, 2018

wking commented Oct 30, 2018

sanchezl commented Oct 30, 2018

abhinavdahiya commented Oct 31, 2018

openshift-merge-robot commented Oct 31, 2018

openshift-merge-robot commented Oct 31, 2018

abhinavdahiya commented Oct 31, 2018

openshift-merge-robot commented Nov 1, 2018

wking Nov 1, 2018

Choose a reason for hiding this comment

deads2k Nov 1, 2018

Choose a reason for hiding this comment

sanchezl Nov 1, 2018

Choose a reason for hiding this comment

deads2k commented Nov 2, 2018

abhinavdahiya commented Nov 2, 2018 • edited Loading

openshift-merge-robot commented Nov 2, 2018

deads2k commented Nov 2, 2018

sanchezl commented Nov 2, 2018

abhinavdahiya commented Nov 5, 2018

openshift-ci-robot commented Nov 5, 2018

deads2k commented Nov 5, 2018

sanchezl commented Oct 26, 2018 •

edited

Loading

abhinavdahiya commented Nov 2, 2018 •

edited

Loading