Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add secret etcd-client.kube-system #581

Merged
merged 1 commit into from
Nov 2, 2018
Merged

add secret etcd-client.kube-system #581

merged 1 commit into from
Nov 2, 2018

Conversation

sanchezl
Copy link
Contributor

Manifest to create this resources belongs in installer. The renderer in
cluster-kube-apiserver-operator will need to be also changed to stop
creating the same manifest file.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2018
@sanchezl sanchezl mentioned this pull request Oct 31, 2018
Closed
abhinavdahiya
abhinavdahiya reviewed Oct 31, 2018
View reviewed changes
pkg/asset/manifests/content/bootkube/kube-system-secret-etcd-client.go Outdated
metadata:
name: etcd-client
namespace: kube-system
labels:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why so many labels ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfojtik , can you help provide insight on purpose of the labels?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For comparison, we have some assets that set tier and k8s-app (like this). We also have some that set kubernetes.io/cluster-service (like this). I'm not clear on if/how any of these labels matter ;).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have deleted all labels.

@wking wking mentioned this pull request Nov 1, 2018
Merged
@sanchezl
manifests: new secret etcd-client.kube-system
50d4627 
Manifest to create this resources belongs in installer. The renderer in
cluster-kube-apiserver-operator will need to be also changed to stop
creating the same manifest file.
@sanchezl sanchezl force-pushed the move_manifest_etcd_client_secret branch from 8ee7b72 to 50d4627 Compare November 1, 2018 14:57
@sanchezl
Copy link
Contributor Author

sanchezl commented Nov 1, 2018

/test images

@sanchezl
Copy link
Contributor Author

sanchezl commented Nov 1, 2018

/test e2e-aws

@wking
Copy link
Member

wking commented Nov 1, 2018

The renderer in cluster-kube-apiserver-operator will need to be also changed...

Are blocked by this, or are good to go here?

@wking
Copy link
Member

wking commented Nov 1, 2018

e2e-aws:

• Failure in Spec Teardown (AfterEach) [622.134 seconds]
[sig-storage] Secrets
/tmp/openshift/build-rpms/rpm/BUILD/origin-4.0.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/common/secrets_volume.go:33
  should be consumable from pods in volume with defaultMode set [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s] [AfterEach]
  /tmp/openshift/build-rpms/rpm/BUILD/origin-4.0.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:684

  Nov  1 15:44:49.300: Couldn't delete ns: "e2e-tests-secrets-vzph9": namespace e2e-tests-secrets-vzph9 was not deleted with limit: timed out waiting for the condition, namespaced content other than pods remain (&errors.errorString{s:"namespace e2e-tests-secrets-vzph9 was not deleted with limit: timed out waiting for the condition, namespaced content other than pods remain"})

  /tmp/openshift/build-rpms/rpm/BUILD/origin-4.0.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:319

I don't understand this change well enough to know if that's real or a flake.

Also, can you rebuild the graph (like d4aaeb8) to pick up your dependency change? If it helps, I can push a commit with the update to your branch.

@deads2k
Copy link
Contributor

deads2k commented Nov 2, 2018

The renderer in cluster-kube-apiserver-operator will need to be also changed...

Are blocked by this, or are good to go here?

No we are not.

I would not expect the failure mode of that flake and CI machines are cheap.

/retest

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2018
@openshift-merge-robot openshift-merge-robot merged commit 20119ed into openshift:master Nov 2, 2018
wking added a commit to wking/openshift-installer that referenced this pull request Nov 2, 2018
@wking
CHANGELOG: Document changes since v0.3.0
3a891bb 
Through 20119ed (Merge pull request openshift#581 from
sanchezl/move_manifest_etcd_client_secret, 2018-11-02).
@sanchezl sanchezl deleted the move_manifest_etcd_client_secret branch November 16, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking left review comments

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@crawford crawford Awaiting requested review from crawford

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sanchezl @wking @deads2k @abhinavdahiya @openshift-ci-robot @openshift-merge-robot