-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add secret etcd-client.kube-system #581
add secret etcd-client.kube-system #581
Conversation
metadata: | ||
name: etcd-client | ||
namespace: kube-system | ||
labels: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why so many labels ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mfojtik , can you help provide insight on purpose of the labels?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have deleted all labels.
Manifest to create this resources belongs in installer. The renderer in cluster-kube-apiserver-operator will need to be also changed to stop creating the same manifest file.
8ee7b72
to
50d4627
Compare
/test images |
/test e2e-aws |
Are blocked by this, or are good to go here? |
I don't understand this change well enough to know if that's real or a flake. Also, can you rebuild the graph (like d4aaeb8) to pick up your dependency change? If it helps, I can push a commit with the update to your branch. |
No we are not. I would not expect the failure mode of that flake and CI machines are cheap. /retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, sanchezl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Through 20119ed (Merge pull request openshift#581 from sanchezl/move_manifest_etcd_client_secret, 2018-11-02).
Manifest to create this resources belongs in installer. The renderer in
cluster-kube-apiserver-operator will need to be also changed to stop
creating the same manifest file.