Bug 2046025: [Alibaba] fix destory exist private zone #5583
Conversation
Should not destroy pre-configured alicloud DNS private zone Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>
openshift-ci
bot
added
the
bugzilla/severity-medium
|
@bd233: This pull request references Bugzilla bug 2046025, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
| @@ -10,5 +10,6 @@ func Metadata(config *types.InstallConfig) *alibabacloud.Metadata { | |||
| return &alibabacloud.Metadata{ | |||
| Region: config.Platform.AlibabaCloud.Region, | |||
| ClusterDomain: config.ClusterDomain(), | |||
| PrivateZoneID: config.AlibabaCloud.PrivateZoneID, | |||
There was a problem hiding this comment.
Generally we try to avoid adding data to the Metadata when it is not necessary, but I do not see another way of determining for certain that the user provided the private dns zone.
| @@ -1205,6 +1207,10 @@ func (o *ClusterUninstaller) detachPolicy(policyName string, policyType string, | |||
| } | |||
|
|
|||
| func (o *ClusterUninstaller) deletePrivateZones(logger logrus.FieldLogger) (err error) { | |||
| if o.PrivateZoneID != "" { | |||
| return nil | |||
There was a problem hiding this comment.
I believe we were relying on this to delete the installer created records in the private dns zone, so I think new logic would need to be added (I could be wrong). I think we can merge this anyway and create a new bug. I would rather leak records than destroy records unintentionally.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@bd233: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/skip |
|
/override ci/prow/e2e-aws ci/prow/e2e-aws-upgrade |
|
@patrickdillon: /override requires a failed status context or a job name to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-aws ci/prow/e2e-aws-upgrade |
|
@patrickdillon: /override requires a failed status context or a job name to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bd233: All pull requests linked via external trackers have merged: Bugzilla bug 2046025 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Should not destroy pre-configured alicloud DNS private zone