Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.10] Bug 2050227: Don't shortcut OpenStack scraping if quota is unavailable #5602

Merged
merged 1 commit into from Feb 4, 2022
Merged

[release-4.10] Bug 2050227: Don't shortcut OpenStack scraping if quota is unavailable #5602

merged 1 commit into from Feb 4, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #5601

/assign mdbooth

@mdbooth
openstack: Don't shortcut cloud scraping if quota is unavailable
e5b9001 
This results in an incorrect failure to validate network capabilities
because network extensions weren't loaded.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 3, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2022

@openshift-cherrypick-robot: Bugzilla bug 2050146 has been cloned as Bugzilla bug 2050227. Retitling PR to link against new bug.
/retitle [release-4.10] Bug 2050227: Don't shortcut OpenStack scraping if quota is unavailable

In response to this:

[release-4.10] Bug 2050146: Don't shortcut OpenStack scraping if quota is unavailable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.10] Bug 2050146: Don't shortcut OpenStack scraping if quota is unavailable [release-4.10] Bug 2050227: Don't shortcut OpenStack scraping if quota is unavailable Feb 3, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2050227, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2050146 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2050146 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

[release-4.10] Bug 2050227: Don't shortcut OpenStack scraping if quota is unavailable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Feb 3, 2022

/retest

@mdbooth
Copy link
Contributor

mdbooth commented Feb 3, 2022

@sdodson We believe this is a release blocker as it prevents installation on a supported cloud configuration (and specifically it prevents installation on PSI). It would be a regression, as it was introduced in 4.10. Are you able to help with the approval process?

@mandre
Copy link
Member

mandre commented Feb 3, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2022

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-alibaba e5b9001 link false /test e2e-alibaba
ci/prow/okd-e2e-gcp-upgrade e5b9001 link false /test okd-e2e-gcp-upgrade
ci/prow/e2e-azurestack e5b9001 link false /test e2e-azurestack
ci/prow/e2e-azurestack-upi e5b9001 link false /test e2e-azurestack-upi
ci/prow/okd-e2e-gcp e5b9001 link false /test okd-e2e-gcp
ci/prow/okd-e2e-vsphere e5b9001 link false /test okd-e2e-vsphere

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson sdodson added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Feb 4, 2022
@sdodson
Copy link
Member

sdodson commented Feb 4, 2022

@mdbooth sounds good, thanks

mandre
mandre reviewed Feb 4, 2022
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit 1ddc64b into openshift:release-4.10 Feb 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2050227 has been moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2050227: Don't shortcut OpenStack scraping if quota is unavailable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@eurijon eurijon Awaiting requested review from eurijon

@mdbooth mdbooth Awaiting requested review from mdbooth

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

Assignees

@mandre mandre

@mdbooth mdbooth

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @mandre @mdbooth @sdodson @openshift-merge-robot