Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.10] Bug 2050227: Don't shortcut OpenStack scraping if quota is unavailable #5602

Merged
merged 1 commit into from
Feb 4, 2022
Merged

[release-4.10] Bug 2050227: Don't shortcut OpenStack scraping if quota is unavailable #5602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 3 additions & 5 deletions pkg/asset/installconfig/openstack/validation/cloudinfo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,13 +211,11 @@ func (ci *CloudInfo) collectInfo(ic *types.InstallConfig, opts *clientconfig.Cli
if err != nil {
if isUnauthorized(err) {
logrus.Warnf("Missing permissions to fetch Quotas and therefore will skip checking them: %v", err)
return nil
}
if isNotFoundError(err) {
} else if isNotFoundError(err) {
logrus.Warnf("Quota API is not available and therefore will skip checking them: %v", err)
return nil
} else {
return errors.Wrap(err, "failed to load Quota")
}
return errors.Wrap(err, "failed to load Quota")
}

ci.NetworkExtensions, err = networkextensions.Get(ci.clients.networkClient)
Expand Down