Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.10] Bug 2052210: Add cloudProviderConfigDataKey to cloud-provider-config map in AWS C2S #5626

Merged
merged 3 commits into from
Feb 11, 2022
Merged

[release-4.10] Bug 2052210: Add cloudProviderConfigDataKey to cloud-provider-config map in AWS C2S #5626

merged 3 commits into from
Feb 11, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #5596

/assign patrickdillon

RedHatDan and others added 3 commits February 8, 2022 21:03
@RedHatDan
Add cloudProviderConfigDataKey to cloud-provider-config map in AWS C2…
3bfa0f8 
…S to resolve BZ 1926975
@dmc5179 @staebler
Update pkg/asset/manifests/cloudproviderconfig.go
cdf6535 
Co-authored-by: Matthew Staebler <staebler@redhat.com>
@dmc5179 @staebler
Update pkg/asset/manifests/cloudproviderconfig.go
c63b5eb 
Co-authored-by: Matthew Staebler <staebler@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 8, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2022

@openshift-cherrypick-robot: Bugzilla bug 1926975 has been cloned as Bugzilla bug 2052210. Retitling PR to link against new bug.
/retitle [release-4.10] Bug 2052210: Add cloudProviderConfigDataKey to cloud-provider-config map in AWS C2S

In response to this:

[release-4.10] Bug 1926975: Add cloudProviderConfigDataKey to cloud-provider-config map in AWS C2S

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.10] Bug 1926975: Add cloudProviderConfigDataKey to cloud-provider-config map in AWS C2S [release-4.10] Bug 2052210: Add cloudProviderConfigDataKey to cloud-provider-config map in AWS C2S Feb 8, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2052210, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1926975 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1926975 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yunjiang@redhat.com), skipping review request.

In response to this:

[release-4.10] Bug 2052210: Add cloudProviderConfigDataKey to cloud-provider-config map in AWS C2S

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 8, 2022
@patrickdillon
Copy link
Contributor

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 8, 2022
@patrickdillon
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2022
@gpei
Copy link
Contributor

gpei commented Feb 8, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 8, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-alibaba c63b5eb link false /test e2e-alibaba
ci/prow/e2e-crc c63b5eb link false /test e2e-crc
ci/prow/e2e-aws-single-node c63b5eb link false /test e2e-aws-single-node
ci/prow/okd-e2e-gcp-upgrade c63b5eb link false /test okd-e2e-gcp-upgrade
ci/prow/okd-e2e-aws c63b5eb link false /test okd-e2e-aws
ci/prow/e2e-azure-upi c63b5eb link false /test e2e-azure-upi
ci/prow/e2e-ibmcloud c63b5eb link false /test e2e-ibmcloud
ci/prow/e2e-openstack-kuryr c63b5eb link false /test e2e-openstack-kuryr
ci/prow/okd-e2e-vsphere c63b5eb link false /test okd-e2e-vsphere
ci/prow/e2e-azurestack c63b5eb link false /test e2e-azurestack
ci/prow/okd-e2e-aws-upgrade c63b5eb link false /test okd-e2e-aws-upgrade
ci/prow/e2e-azurestack-upi c63b5eb link false /test e2e-azurestack-upi
ci/prow/e2e-aws-workers-rhel8 c63b5eb link false /test e2e-aws-workers-rhel8
ci/prow/okd-e2e-gcp c63b5eb link false /test okd-e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

25 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@sdodson sdodson added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Feb 11, 2022
@sdodson
Copy link
Member

sdodson commented Feb 11, 2022

Needed for backports so adding staff-eng-approved

@openshift-merge-robot openshift-merge-robot merged commit 5349373 into openshift:release-4.10 Feb 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 11, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2052210 has been moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2052210: Add cloudProviderConfigDataKey to cloud-provider-config map in AWS C2S

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@openshift-cherrypick-robot @patrickdillon @gpei @openshift-bot @sdodson @openshift-merge-robot @RedHatDan @dmc5179