Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #5665 from r4f4/azure-azid-adapter" #5722

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Mar 17, 2022

This reverts commit 26f8c53, reversing
changes made to 3c4a5fb.

Microsoft has decided to push back on the deprecation until the end of
the year [1]. So we have decided to revert the changes to the
authentication until the new API is stable.

[1] https://docs.microsoft.com/en-us/graph/migrate-azure-ad-graph-overview

This reverts commit 26f8c53, reversing
changes made to 3c4a5fb.

Microsoft has decided to push back on the deprecation until the end of
the year [1]. So we have decided to revert the changes to the
authentication until the new API is stable.

[1] https://docs.microsoft.com/en-us/graph/migrate-azure-ad-graph-overview
@patrickdillon
Copy link
Contributor

/test e2e-azure

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2022

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc dbb9a49 link false /test e2e-crc
ci/prow/okd-e2e-aws-upgrade dbb9a49 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 dbb9a49 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-ibmcloud dbb9a49 link false /test e2e-ibmcloud
ci/prow/e2e-azure-upi dbb9a49 link false /test e2e-azure-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 72fbd84 into openshift:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants