azure: support selecting marketplace image in install config #5799
Conversation
|
@staebler when the PR is rebased to branch master, please notify me, I can do pre-merge test. thanks a lot. |
openshift-ci
bot
added
the
needs-rebase
staebler
force-pushed
the
azure_marketplace
branch
from
b4fde97
to
aaba77d
Compare
openshift-ci
bot
removed
the
needs-rebase
|
|
nice work! |
openshift-ci
bot
added
lgtm
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@staebler master nodes will support customize the image with market image ? based on my test, just worker nodes use the market image. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@staebler test with pr-merge, Failed. $ oc describe machine maxu-5799-q44n6-worker-southcentralus1-h8sqv -n openshift-machine-api Warning FailedCreate 125m azure-controller CreateError: failed to reconcile machine "maxu-5799-q44n6-worker-southcentralus1-h8sqv"s: failed to create vm maxu-5799-q44n6-worker-southcentralus1-h8sqv: failed to create or get machine: compute.VirtualMachinesCreateOrUpdateFuture: asynchronous operation has not completed |
Only the worker nodes can use market images. |
staebler
force-pushed
the
azure_marketplace
branch
3 times, most recently
from
645815a
to
44e3123
Compare
|
|
test pass with installer_payload_image: registry.build01.ci.openshift.org/ci-ln-dk40i2t/release:latest |
|
@MayXuQQ: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
qe-approved
|
we will support customize the osImage in installconfig.control.platform.azure.osImage, installconfig.compute.platform.azure.osImage and installconfig.platform.azure.defaultMachinePlatform.osImage, even the market Image just can be used in installconfig.compute.platform.azure.osImage , right ? @staebler |
No. The validation should fail if the fields of |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Vendor in additional packages from github.com/Azure/azure-sdk-for-go to support the calls needed to validate Azure marketplace images.
Additional fields added to Azure machine pools that give the user the option to select the marketplace image to use for the OS image. The OS image can only be selected for compute machine pools. Validation will be performed that (1) the marketplace image selected exists and (2) that the license terms for the marketplcae image selected have been accepted. ``` osImage: publisher: <string> offer: <string> sku: <string> version: <string> ``` https://issues.redhat.com/browse/CORS-1824
Re-generate the mock for the Azure client so that the additional functions added to support marketplace images are included in the mock.
Add unit tests for the static validation of marketplace images selected in the install config.
Add unit tests for the dynamic validation of the Azure marketplace images.
staebler
force-pushed
the
azure_marketplace
branch
from
44e3123
to
768e914
Compare
|
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@staebler: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
Bad rebase. Close in favor of #5839 |
|
/close |
openshift-ci
bot
added
the
needs-rebase
|
@staebler: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@patrickdillon: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Additional fields added to Azure machine pools that give the user the option to select the marketplace image to use for the OS image. The OS image can only be selected for compute machine pools. Validation will be performed that (1) the marketplace image selected exists and (2) that the license terms for the marketplcae image selected have been accepted.
https://issues.redhat.com/browse/CORS-1824