Fixup Azure marketplace pr 5799 #5839
Conversation
Vendor in additional packages from github.com/Azure/azure-sdk-for-go to support the calls needed to validate Azure marketplace images.
Additional fields added to Azure machine pools that give the user the option to select the marketplace image to use for the OS image. The OS image can only be selected for compute machine pools. Validation will be performed that (1) the marketplace image selected exists and (2) that the license terms for the marketplcae image selected have been accepted. ``` osImage: publisher: <string> offer: <string> sku: <string> version: <string> ``` https://issues.redhat.com/browse/CORS-1824
Re-generate the mock for the Azure client so that the additional functions added to support marketplace images are included in the mock.
Add unit tests for the static validation of marketplace images selected in the install config.
Add unit tests for the dynamic validation of the Azure marketplace images.
openshift-ci
bot
added
the
tide/merge-method-squash
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
https://issues.redhat.com/browse/CORS-1824 |
#5799 must have had a bad rebase. staebler's repo does not seem to accept my pushes so I'm opening this as a new PR.
I've included the simple fixup as a separate fixup commit:
/label tide/merge-method-squash