Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsphere upi: missing etc resolv #5842

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

jcpowermac
Copy link
Contributor

Using rc-manager=unmanaged
for vsphere upi breaks the bootstrap
process since the RHCOS instance has
no /etc/resolv.conf

Using rc-manager=unmanaged
for vsphere upi breaks the bootstrap
process since the RHCOS instance has
no `/etc/resolv.conf`
@openshift-ci openshift-ci bot requested review from kirankt and sadasu April 25, 2022 18:52
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jcpowermac after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcpowermac
Copy link
Contributor Author

/test e2e-vsphere-upi

@cybertron
Copy link
Member

/lgtm

This logic matches what's used in the dispatcher script[0] so it should do what we want.

0:

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2022
@deads2k
Copy link
Contributor

deads2k commented Apr 25, 2022

UPI install worked. per the bot it seems to only need approved labels. Nothing has merged this was opened. Merging

@deads2k deads2k merged commit e560f01 into openshift:master Apr 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2022

@jcpowermac: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-upi 00683f1 link false /test e2e-vsphere-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants