Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default machine pool config for Nutanix #5857

Merged
merged 1 commit into from May 4, 2022
Merged

Change the default machine pool config for Nutanix #5857

merged 1 commit into from May 4, 2022

Conversation

thunderboltsid
Copy link
Contributor

@thunderboltsid thunderboltsid commented May 1, 2022 •
edited

Adjust the default machine pool configuration for Nutanix machines

  • Reduce the number of cores per socket:
    • Control plane nodes: From 4 cores per socket to 1
    • Worker nodes: From 2 cores per socket to 1
  • Increase the number of CPUs:
    • Control plane nodes: From 4 CPUs to 8
    • Worker nodes: From 2 CPUs to 4
  • Increased the RAM to 16GB.

Note: The AHV scheduler treats socket and core allocation exactly the same.

@openshift-ci openshift-ci bot requested review from jstuever and r4f4 May 1, 2022 00:05
@thunderboltsid
Copy link
Contributor Author

/retest-required

@thunderboltsid thunderboltsid mentioned this pull request May 2, 2022
Merged
@thunderboltsid
Copy link
Contributor Author

/hold
There's another PR that is increasing the number of cores in default machine pool.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2022
@thunderboltsid
Change the default machine pool config for Nutanix
76d5d36 
Adjust the default machine pool configuration for Nutanix machines
  - Reduce the number of cores per socket:
    - Control plane nodes: From 4 cores per socket to 1
    - Worker nodes: From 2 cores per socket to 1
  - Increase the number of CPUs:
    - Control plane nodes: From 4 CPUs to 8
    - Worker nodes: From 2 CPUs to 4
  - Increased the RAM to 16GB
@thunderboltsid thunderboltsid force-pushed the ntnx-reduce-control-plane-cpu branch from 74b2786 to 76d5d36 Compare May 2, 2022 17:26
@thunderboltsid thunderboltsid changed the title Change the number of cores for Nutanix machines Change the default machine pool config for Nutanix May 2, 2022
@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented May 2, 2022 •
edited

/hold cancel
Canceling the hold. @rna-afk says we can take care of modifying the Nutanix defaults in this PR.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2022
@thunderboltsid
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2022

@thunderboltsid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc 76d5d36 link false /test e2e-crc
ci/prow/okd-e2e-aws 76d5d36 link false /test okd-e2e-aws
ci/prow/e2e-openstack 76d5d36 link false /test e2e-openstack
ci/prow/e2e-ibmcloud 76d5d36 link false /test e2e-ibmcloud
ci/prow/e2e-libvirt 76d5d36 link false /test e2e-libvirt
ci/prow/e2e-metal-ipi 76d5d36 link false /test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rna-afk
Copy link
Contributor

rna-afk commented May 3, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2022
@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented May 3, 2022 •
edited

/assign @patrickdillon
for approval

@patrickdillon
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f29b733 into openshift:master May 4, 2022
@thunderboltsid thunderboltsid deleted the ntnx-reduce-control-plane-cpu branch May 25, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@r4f4 r4f4 Awaiting requested review from r4f4

Assignees

@rna-afk rna-afk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thunderboltsid @rna-afk @patrickdillon @openshift-bot @openshift-merge-robot